Bug 1581718 - Avoid strange results for orthogonal-flow cases in CalculateBlockSideMargins when border/padding/margin are present. r=jfkthame

Differential Revision: https://phabricator.services.mozilla.com/D46143

--HG--
extra : moz-landing-system : lando

Bug 1579311 - Adjust the order of the buttons in the confirmation dialog based on OS and focus the confirmation button by default. r=MattN

Differential Revision: https://phabricator.services.mozilla.com/D45274

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45702

--HG--
extra : moz-landing-system : lando

- Don't store whole buffer update information at mWholeWindowBufferDamage but use damage region instead.
- Check and remove overlapped images when they are stored at image cache.
- Remove CanDrawToWaylandBufferDirectly() as it's not very useful.

This commit depends on Bug 1580152 which needs to land first.

Differential Revision: https://phabricator.services.mozilla.com/D46140

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D46038

--HG--
extra : moz-landing-system : lando

- Recently we're missing some drawings as we disabled flushing cached images in frame callback. Let's enable it again and make sure we don't flush the drawings between Lock()/Commit() compositor calls which is controlled by mBufferCommitAllowed.

- When we draw directly to wl_buffer, flush all cached drawings we have or clear them if there's fullscreen update. It prevents potential rendering of cached images over unrelevant buffer content.

- Flush cached images when wl_buffer is detached by wayland compositor. It allows to paint delayed drawings and ensures they won't stay in the queue infinitely.

- Use mBufferPendingCommit to indicate that the WaylandBuffer contains updates from gecko which has not been submitted to wayland compositor yet. Allows delated commit handlers (frame callback, delayed commit and when wl_buffer is detached) to send WaylandBuffer content to wayland compositor.

- Record time of last finished commit to mLastCommitTime and throws warning when wayland compositor does not release wl_buffer in 200ms.

- Use wl_display_sync() to synchronize wl_display events. Wait for events from wl_display until all pending events are processed before we start drawing at WindowSurfaceWayland::Lock(). There may wl_buffer release event waiting which releases wl_buffer for rendering.

- Don't use XMost()/YMost() to get drawing area size.

- Remove mDisplayThreadMessageLoop as it's no longer used.

Differential Revision: https://phabricator.services.mozilla.com/D45661

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45904

--HG--
extra : moz-landing-system : lando

Bug 1581014 - Select the login item on keyup instead of keydown to prevent the 'Edit' button, which gets focused on login selection, from getting an erroneous click event. r=MattN

Differential Revision: https://phabricator.services.mozilla.com/D45898

--HG--
extra : moz-landing-system : lando

Bug 1580859 - Keyboard navigation in the login-list should cycle through only visible login-list-items. r=sfoster

Differential Revision: https://phabricator.services.mozilla.com/D45894

--HG--
extra : moz-landing-system : lando

If a docshell is swapped, we will need to update the targets. Any stale targets will get cleaned up by the subscriber iterator.

Differential Revision: https://phabricator.services.mozilla.com/D45890

--HG--
extra : moz-landing-system : lando

Bug 1580450 - Move tab focus to the origin input when no logins are present and the 'create' mode is entered. r=MattN

Differential Revision: https://phabricator.services.mozilla.com/D45889

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D44910

--HG--
extra : moz-landing-system : lando

Bug 1581804 - Adjust webrender+geckoview reftest thresholds after blob recoordination changes. r=jnicol

Differential Revision: https://phabricator.services.mozilla.com/D46142

--HG--
extra : moz-landing-system : lando

Bug 1579489 - Check the persistent permission checkbox by default for WebExtension WebRTC prompts. r=jib

This is done to offset the requirement that extensions have to get persistent permission before
they can start using WebRTC in popups.

Differential Revision: https://phabricator.services.mozilla.com/D45335

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45334

--HG--
extra : moz-landing-system : lando

The goal is to

- Avoid showing any permission prompt when calling getUserMedia in webextension popups,
  while still checking for persistent permissions.
- Never allow getUserMedia calls on background pages.

Differential Revision: https://phabricator.services.mozilla.com/D45333

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D46145

--HG--
extra : moz-landing-system : lando

Bug 1581377 - Let display:flex not override the hidden attribute on the one off search button container. r=harry

Differential Revision: https://phabricator.services.mozilla.com/D46124

--HG--
extra : moz-landing-system : lando

Bug 1579420 - Fix remaining ESLint no-async-promise-executor issues in browser/ and toolkit/. r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D45010

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45009

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45500

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D46130

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45785

--HG--
extra : moz-landing-system : lando

The thread calls into some windows APIs that may sometimes block for a long time. Since we're shutting down anyway, it is OK to sometimes leak this thread, similar to what we do for DNS resolver threads.

The patch converts nsNotifyAddrListener::mThread to a nsIThreadPool (with a max of 1 thread) so that we may call shutdownWithTimeout on it.

Differential Revision: https://phabricator.services.mozilla.com/D46002

--HG--
extra : moz-landing-system : lando

The Telemetry::AccumulateTimeDelta function reports in milliseconds but I had
assumed seconds when I added the hostname obfuscation ICE duration histogram.
This change adjusts the "high" value accordingly.

With the telemetry we've collected to date, 60% of the values are below 600
milliseconds, so I think that setting a high value of 30 seconds should be
sufficient even if there is a long tail. Since this does not change the data
being collected, no additional data-review is required, but it does require
renaming the key.

Differential Revision: https://phabricator.services.mozilla.com/D46045

--HG--
extra : moz-landing-system : lando

Depends on D45996

Differential Revision: https://phabricator.services.mozilla.com/D45997

--HG--
extra : moz-landing-system : lando

Flushing on mprotect is a lot simpler and it's easier to reason about
correctness. The next patch will remove the AutoFlushICache infrastructure.

Because mprotect is pretty expensive we've been moving away from code patching
in perf-sensitive cases so I don't expect any serious regressions from this.
(This patch could be optimized more, if needed, but it'd add more complexity.)

Differential Revision: https://phabricator.services.mozilla.com/D45996

--HG--
extra : moz-landing-system : lando

This restores the code for generating devicechange events that was
accidentally removed as part of updating the Windows video capture code
in Bug 1552755.

Differential Revision: https://phabricator.services.mozilla.com/D46033

--HG--
extra : moz-landing-system : lando

Bug 1580185. Clicking on clear button in the Search panel doesn't cancel the current search. r=Honza.

Differential Revision: https://phabricator.services.mozilla.com/D46047

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D40100

--HG--
extra : moz-landing-system : lando

Bug 1580130 - Add telemetry to record presence of the networkID when the connectivity check has completed r=dragana

When the IPv4 check is completed, we get the network ID and report to telemetry if it was empty or not. This allows us to more accurately determine if we always have a networkID.

Depends on D45331

Differential Revision: https://phabricator.services.mozilla.com/D45332

--HG--
extra : moz-landing-system : lando

Since we sometimes coalesce SendEvents, calling it from there is not actually correct, and sometimes we fail to recompute the networkID when network changes happen.

Differential Revision: https://phabricator.services.mozilla.com/D45331

--HG--
extra : moz-landing-system : lando

Backed out changeset 281d238e6259 (bug 1579489)
Backed out changeset 764628963a3c (bug 1579489)
Backed out changeset 680a45ca89b7 (bug 1579489)

Differential Revision: https://phabricator.services.mozilla.com/D45922

--HG--
extra : moz-landing-system : lando

Bug 1561443 - Move _getErrorMessageFromCode from NetErrorChild.jsm to aboutNetError.js. r=fluent-reviewers,flod,johannh

Differential Revision: https://phabricator.services.mozilla.com/D36542

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45540

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45550

--HG--
extra : moz-landing-system : lando

Bug 1581071 - Update devtools metrics test to check that modules are not loaded twice r=Honza,ochameau

Check for duplicated entries in the loaders during the metrics tests

Differential Revision: https://phabricator.services.mozilla.com/D45833

--HG--
extra : moz-landing-system : lando

Bug 1579489 - Check the persistent permission checkbox by default for WebExtension WebRTC prompts. r=jib

This is done to offset the requirement that extensions have to get persistent permission before
they can start using WebRTC in popups.

Differential Revision: https://phabricator.services.mozilla.com/D45335

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D45334

--HG--
extra : moz-landing-system : lando