Skip to content
Snippets Groups Projects
  1. Aug 26, 2024
  2. Aug 24, 2024
  3. Aug 08, 2024
  4. Jul 27, 2024
    • Kelsey Gilbert's avatar
      Bug 1885245 - Remove PlainOldDataSerializer. r=mccr8 a=RyanVM · 2b8bf0f7
      Kelsey Gilbert authored
      There's no sufficiently robust way to identify POD types in C++, such
      that we could rely on this kind of thing for serialization.
      
      As one example, `bool` must be carefully handled on deserialize, in case
      an attacker wants to exploit the UB of bool with value 2.
      Additionally, generally it's not viable to tell whether all the members
      of a struct are PODs as well, and we need that level of assurance
      recursively!
      
      So we instead lean on e.g. ParamTraits_TiedFields/_IsEnumCase for our
      extreme robustness requirements.
      
      Differential Revision: https://phabricator.services.mozilla.com/D217518
      2b8bf0f7
  5. Jul 24, 2024
  6. Aug 22, 2024
  7. Aug 20, 2024
  8. Aug 19, 2024
  9. Jul 25, 2024
  10. Aug 22, 2024
  11. Aug 15, 2024
  12. Aug 22, 2024
  13. Aug 21, 2024
  14. Aug 01, 2024
    • stransky's avatar
      Bug 1904424 [Linux/X11] Don't steal focus on X11 r=emilio a=RyanVM · 07529434
      stransky authored
      The patch comes from https://gitlab.com/redhat/centos-stream/rpms/firefox/-/merge_requests/94
      
      Firefox isn't currently handling window focusing right on X11... There's a few problems:
      
      If no startup id is provided, it tries to get user time from g_get_monotonic_time when there's no guarantee that timestamp is synchronized or even in a compatible unit. This merge request addressed that by dropping the code that uses g_get_monotonic_time entirely, and instead adding a heuristic to synthesize a startup id based on the time of the last user interaction on the display. This makes an assumption that firefox was started as a result of user interaction, which might not always hold true, but it's more likely than not, and is basically the same assumption firefox is already making by trying to use a timestamp of "now" (g_get_monotonic_time) when focusing the window.
      
      If a startup id is provided, it fails to tell gtk to use it when focusing the window because it calls gtk_window_present_with_time with some other random timestamp instead of passing GDK_CURRENT_TIME (which is the magic value that means "use startup id for timestamp"). This commit tries to detect when a startup id is available, and the display is X11, and if so use a timestamp of GDK_CURRENT_TIME.
      
      Differential Revision: https://phabricator.services.mozilla.com/D217174
      07529434
  15. Jul 22, 2024
  16. Jul 18, 2024
  17. Jun 13, 2024
  18. Jul 05, 2024
  19. Aug 21, 2024
Loading