Skip to content
Snippets Groups Projects
  1. Feb 21, 2024
  2. Nov 20, 2023
    • Jonathan Kew's avatar
      Bug 1865482 - Make CSS :lang() matching more correctly follow the BCP4647... · be58953c
      Jonathan Kew authored
      Bug 1865482 - Make CSS :lang() matching more correctly follow the BCP4647 Extended Filtering algorithm. r=layout-reviewers,emilio a=RyanVM
      
      The matching behavior implemented in bug 1857742 did not quite follow the spec,
      particularly with regard to language *ranges* (as used in the :lang() pseudo)
      that are not themselves valid language *tags*.
      
      This updates the LangTagCompare function to more correctly follow the BCP4647
      "Extended Filtering" algorithm, and adjusts the relevant WPT tests (originally
      from bug 1857742) to reflect the corrected behavior.
      
      Differential Revision: https://phabricator.services.mozilla.com/D194054
      be58953c
  3. Dec 07, 2023
  4. Oct 16, 2023
  5. Jun 14, 2023
  6. Jun 06, 2023
  7. Jun 04, 2023
    • Rob Wu's avatar
      Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs... · 3c0c3a26
      Rob Wu authored
      Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
      
      This patch was generated as follows:
      
      Run:
      `./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
      In the output there are linter/prettifier errors due to unused
      XPCOMUtils or separate importESModule calls. These have been fixed
      manually and verified with `./mach lint --outgoing`.
      
      The `esmify` script also inserts many unwanted newlines around imports
      that are broken on two lines due to length. Due to the number of these,
      I fixed them programatically.
      
      1. Create patch from the changes so far.
      2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
      3. Reset the working dir and apply the revised patch.
      4. Verify that the diff between step 1 and 3 looks reasonable.
      5. Verify that this patch as a whole looks reasonable.
      
      Commands:
      
      ```
      git diff > rename.diff
      :%g/^+$/d
      git commit -va -m WIP-rename
      git revert HEAD
      git apply --recount rename.diff
      git diff HEAD^  # and verify that the removed lines are ok.
      git commit -va  # one last review to verify correctness of whole patch.
      git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
      ```
      
      `git apply` has the `--recount` option to force it to ignore mismatches
      in line counts, which happens because we deleted added lines (^+$)
      without fixing up the line counts in the file headers.
      
      Differential Revision: https://phabricator.services.mozilla.com/D179874
      3c0c3a26
  8. Jun 02, 2023
  9. May 27, 2023
  10. May 25, 2023
  11. May 24, 2023
  12. May 23, 2023
  13. May 20, 2023
  14. May 08, 2023
  15. Apr 20, 2023
  16. Mar 30, 2023
  17. Mar 29, 2023
  18. Mar 23, 2023
  19. Mar 22, 2023
Loading