Skip to content
Snippets Groups Projects
  1. Sep 09, 2021
  2. Jun 16, 2020
  3. Feb 27, 2020
  4. Apr 02, 2019
    • David Major's avatar
      Bug 1536675 - Take the crashing out of MOZ_CrashPrintf r=froydnj · c7531ea3
      David Major authored
      It would be helpful if MOZ_CRASH_UNSAFE_PRINTF would do its crashing inline at the caller, so that CI failure logs can blame the right code.
      
      Before this patch, MOZ_CRASH_UNSAFE_PRINTF calls MOZ_CrashPrintf, which does the printf work and crashes.
      
      This patch pulls out the crashing piece at the end, so that MOZ_CrashPrintf only does the printf work, and returns the string to the caller, who will MOZ_Crash inline.
      
      Differential Revision: https://phabricator.services.mozilla.com/D25329
      
      --HG--
      extra : moz-landing-system : lando
      c7531ea3
  5. Feb 03, 2019
  6. Nov 30, 2018
  7. Nov 14, 2018
  8. Nov 13, 2018
    • Mike Hommey's avatar
      Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj · 661cef9f
      Mike Hommey authored
      Because we don't really need all this repetition.
      
      Depends on D11718
      
      Differential Revision: https://phabricator.services.mozilla.com/D11719
      
      --HG--
      extra : moz-landing-system : lando
      661cef9f
    • Mike Hommey's avatar
      Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj · 5934f74c
      Mike Hommey authored
      Ideally, we'd want the function to stay in Assertions.cpp, but that's
      only part of MFBT proper, and that doesn't have access to WalkTheStack
      like MOZ_CRASH has from being in Assertion.h, when included from Gecko
      code. Moving WalkTheStack to mozglue, putting it close together with
      MozStackWalk would be prefered, but that causes problems linking MFBT
      tests (which don't have access to mozglue), and other things.
      
      Overall, this was too deep a rabbit hole, and moving MOZ_CrashOOL to
      Assertions.h is much simpler. Since it's essentially the same as
      MOZ_CRASH, except it allows non-literal strings, we can make it inlined,
      and leave it to the compiler to drop the filename argument when it's not
      used.
      
      Differential Revision: https://phabricator.services.mozilla.com/D11718
      
      --HG--
      extra : moz-landing-system : lando
      5934f74c
  9. Nov 14, 2018
    • Mike Hommey's avatar
      Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj · 08f7e29c
      Mike Hommey authored
      Because we don't really need all this repetition.
      
      Depends on D11718
      
      Depends on D11718
      
      Differential Revision: https://phabricator.services.mozilla.com/D11719
      
      --HG--
      extra : moz-landing-system : lando
      08f7e29c
    • Mike Hommey's avatar
      Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj · b60c5c12
      Mike Hommey authored
      Ideally, we'd want the function to stay in Assertions.cpp, but that's
      only part of MFBT proper, and that doesn't have access to WalkTheStack
      like MOZ_CRASH has from being in Assertion.h, when included from Gecko
      code. Moving WalkTheStack to mozglue, putting it close together with
      MozStackWalk would be prefered, but that causes problems linking MFBT
      tests (which don't have access to mozglue), and other things.
      
      Overall, this was too deep a rabbit hole, and moving MOZ_CrashOOL to
      Assertions.h is much simpler. Since it's essentially the same as
      MOZ_CRASH, except it allows non-literal strings, we can make it inlined,
      and leave it to the compiler to drop the filename argument when it's not
      used.
      
      Differential Revision: https://phabricator.services.mozilla.com/D11718
      
      --HG--
      extra : moz-landing-system : lando
      b60c5c12
  10. Jul 21, 2018
  11. Feb 22, 2017
  12. Feb 21, 2017
  13. Nov 07, 2016
  14. May 21, 2012
  15. Jun 07, 2012
  16. Jun 04, 2012
  17. Apr 09, 2012
  18. Feb 13, 2012
  19. Nov 23, 2011
  20. Nov 09, 2011
  21. Mar 01, 2012
  22. Jun 06, 2011
  23. May 03, 2011
  24. Apr 28, 2011
  25. Apr 20, 2011
  26. Apr 01, 2011
  27. Apr 27, 2010
  28. Apr 16, 2010
  29. Jan 22, 2009
Loading