Commits · FIREFOX_115_9_1esr_BUILD1 · The Tor Project / Applications / Mullvad Browser

May 26, 2023

Bug 1791961 - mfbt: constify some operators to fix C++20... · 32b7b4e8

Chris Peterson authored 1 year ago

Bug 1791961 - mfbt: constify some operators to fix C++20 -Wambiguous-reversed-operator warnings. r=glandium

clang is warning that C++20 expects comparison operators to be commutative: `a == b` and `b == a` should resolve to the same comparison operator function. Warnings about the comparison of const and non-const objects can be fixed by making the comparison operator function const.

mfbt/tests/TestDoublyLinkedList.cpp:158:36 [-Wambiguous-reversed-operator] ISO C++20 considers use of overloaded operator '==' (with operand types 'SomeClass' and 'SomeClass') to be ambiguous despite there being a unique best viable function
mfbt/tests/TestDoublyLinkedList.cpp:159:38 [-Wambiguous-reversed-operator] ISO C++20 considers use of overloaded operator '==' (with operand types 'SomeClass' and 'SomeClass') to be ambiguous despite there being a unique best viable function

Depends on D179022

Differential Revision: https://phabricator.services.mozilla.com/D179023

32b7b4e8

May 24, 2023

Bug 1821362 - Replace EuclidGCD by a binary gcd algorithm using intrinsics.... · 23ce79a8

Paul Adenot authored 1 year ago

Bug 1821362 - Replace EuclidGCD by a binary gcd algorithm using intrinsics. r=media-playback-reviewers,alwu

Perf notes:
https://lemire.me/blog/2013/12/26/fastest-way-to-compute-the-greatest-common-divisor/

Differential Revision: https://phabricator.services.mozilla.com/D173315

23ce79a8

May 19, 2023

Backed out 80 changesets (bug 1821362, bug 1703812, bug ) for causing... · 5fd965f0

Cosmin Sabou authored 1 year ago

Backed out 80 changesets (bug 1821362, bug 1703812, bug 18179974) for causing media crashes as in Bug 1833890. a=backout

Backed out changeset f2113c9b661f (bug 18179974)
Backed out changeset f1ecfbba7ed2 (bug 1703812)
Backed out changeset 011cece33b0d (bug 18179974)
Backed out changeset 4b42659090f3 (bug 18179974)
Backed out changeset 2d92f903dd66 (bug 18179974)
Backed out changeset 0ef13d357ee3 (bug 18179974)
Backed out changeset 7353f869efd2 (bug 1703812)
Backed out changeset 14b061d0f595 (bug 18179974)
Backed out changeset d29bc29397c8 (bug 1703812)
Backed out changeset 54c3294f0839 (bug 18179974)
Backed out changeset b9f2e1155bd7 (bug 18179974)
Backed out changeset d5d5d390dcbf (bug 18179974)
Backed out changeset 8fca27bd0f6b (bug 18179974)
Backed out changeset 670c599a3b99 (bug 18179974)
Backed out changeset deea3077f762 (bug 18179974)
Backed out changeset 25ecea0f3d49 (bug 18179974)
Backed out changeset 35ab3ed5e3fc (bug 18179974)
Backed out changeset f516a428ba32 (bug 18179974)
Backed out changeset e589b4d30995 (bug 18179974)
Backed out changeset d096b9cc905d (bug 18179974)
Backed out changeset 2952a6fa06e5 (bug 18179974)
Backed out changeset c1ac4c31ad9a (bug 18179974)
Backed out changeset 04c60cd83c5f (bug 1821362)
Backed out changeset 6dd80575e551 (bug 1821362)
Backed out changeset b86b569ecd46 (bug 18179974)
Backed out changeset 412e0a9ec4e8 (bug 18179974)
Backed out changeset 8e0dcf163138 (bug 18179974)
Backed out changeset 7af506896930 (bug 18179974)
Backed out changeset 29f7cd2b341c (bug 18179974)
Backed out changeset 7f64e65d9497 (bug 18179974)
Backed out changeset 89c241451a32 (bug 18179974)
Backed out changeset 66e4a26e1ebe (bug 18179974)
Backed out changeset ea1aebd4e245 (bug 18179974)
Backed out changeset 2d88a5915db9 (bug 18179974)
Backed out changeset 697ec1928f9c (bug 18179974)
Backed out changeset 41c0bd1133c5 (bug 18179974)
Backed out changeset b20cc750c020 (bug 18179974)
Backed out changeset dc5fd84a3a4c (bug 1703812)
Backed out changeset efa6d130d4eb (bug 1703812)
Backed out changeset 20d9b7cf0ddc (bug 1703812)
Backed out changeset e77c61e8fad2 (bug 1703812)
Backed out changeset 582d5c680e5a (bug 1703812)
Backed out changeset 96c9aacc6811 (bug 1703812)
Backed out changeset 56ec4a57a6a6 (bug 1703812)
Backed out changeset 8f96c8811675 (bug 1703812)
Backed out changeset a79a2f1b2b51 (bug 1703812)
Backed out changeset 07eb8b2c5b9f (bug 1703812)
Backed out changeset bae2b2fb9759 (bug 1703812)
Backed out changeset 38b0416538f3 (bug 1703812)
Backed out changeset b27b54c95cf2 (bug 1703812)
Backed out changeset cab00065d83d (bug 1703812)
Backed out changeset ab44727b2e1a (bug 1703812)
Backed out changeset b7fdcb494670 (bug 1703812)
Backed out changeset 73db43d49c6d (bug 1703812)
Backed out changeset ce754dbfb862 (bug 1703812)
Backed out changeset d694726a3ee6 (bug 1703812)
Backed out changeset 6acede55acbb (bug 1703812)
Backed out changeset 86e7d4784a20 (bug 1703812)
Backed out changeset 6b2e055d9314 (bug 1703812)
Backed out changeset b08695e5728a (bug 1703812)
Backed out changeset 3b8a0081fd10 (bug 1703812)
Backed out changeset 3a163596f982 (bug 1703812)
Backed out changeset 5be1d4b282ab (bug 1703812)
Backed out changeset 1ce012d7509e (bug 1703812)
Backed out changeset ee2fab5881c7 (bug 1703812)
Backed out changeset 62941a522893 (bug 1703812)
Backed out changeset d4f11dc33eed (bug 1703812)
Backed out changeset 781bb4c3cc02 (bug 1703812)
Backed out changeset f070e0de0566 (bug 1703812)
Backed out changeset 9f65c67ba2a6 (bug 1703812)
Backed out changeset 1e76eecb85e2 (bug 1703812)
Backed out changeset 953432408a83 (bug 1703812)
Backed out changeset fd1dc92d3911 (bug 1703812)
Backed out changeset 34d56948c6b6 (bug 1703812)
Backed out changeset 2ba7ca61ecc3 (bug 1703812)
Backed out changeset 545253c469e6 (bug 1703812)
Backed out changeset fb4a61ab1300 (bug 1703812)
Backed out changeset bf07b3cfd3d5 (bug 1703812)
Backed out changeset eaff51e7754b (bug 1703812)
Backed out changeset f5c485c41d13 (bug 1703812)

5fd965f0

May 17, 2023

Bug 1821362 - Replace EuclidGCD by a binary gcd algorithm using intrinsics.... · 281091bd

Paul Adenot authored 1 year ago

Bug 1821362 - Replace EuclidGCD by a binary gcd algorithm using intrinsics. r=media-playback-reviewers,alwu

Perf notes:
https://lemire.me/blog/2013/12/26/fastest-way-to-compute-the-greatest-common-divisor/

Differential Revision: https://phabricator.services.mozilla.com/D173315

281091bd

Apr 18, 2023

Bug 1679492 - Remove parts that are unused from mfbt/TemplateLib. r=sergesanspaille · 3d035ca8

Andi-Bogdan Postelnicu authored 1 year ago

Some implementations from TemplateLib are easily changeable with std functionality.
mozilla::tl::And has been removed and replaced with std::conjuction

Differential Revision: https://phabricator.services.mozilla.com/D175762

3d035ca8

Bug 1826756 - Make mfbt/tests/gtest buildable outside of a unified build environment r=andi · 84f40322
serge-sans-paille authored 1 year ago
```
Differential Revision: https://phabricator.services.mozilla.com/D174881
```
84f40322

Apr 17, 2023

Bug 1277372 - Remove unused "mozilla/TypeTraits.h" r=sergesanspaille · 79e171fd
Andi-Bogdan Postelnicu authored 1 year ago
```
Differential Revision: https://phabricator.services.mozilla.com/D174129
```
79e171fd

Bug 1277372 - Move away from "mozilla/TypeTraits.h". r=geckoview-reviewers,sergesanspaille,m_kato · bf2bb593

Andi-Bogdan Postelnicu authored 1 year ago

std::is_pod has been deprecated in C++20, see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0767r1.html.
This is equivalent with std::is_trivial_v && std::is_standard_layout.

Differential Revision: https://phabricator.services.mozilla.com/D174128

bf2bb593

Backed out 9 changesets (bug 1826760, bug 1826758, bug 1826752, bug 1826756,... · cefd9267

Stanca Serban authored 1 year ago

Backed out 9 changesets (bug 1826760, bug 1826758, bug 1826752, bug 1826756, bug 1826759, bug 1826761, bug 1826757, bug 1826753, bug 1826754) for causing bp-hybrid bustages in ClearKeyDecryptionManager.cpp.
CLOSED TREE

Backed out changeset 210012222277 (bug 1826761)
Backed out changeset e364bb149efa (bug 1826760)
Backed out changeset e456e2f9966c (bug 1826759)
Backed out changeset 2b6ff545f4a3 (bug 1826758)
Backed out changeset 95fe1de8ba00 (bug 1826757)
Backed out changeset f8af52d7f2a1 (bug 1826756)
Backed out changeset 2646e773f098 (bug 1826754)
Backed out changeset 58d5d74b1835 (bug 1826753)
Backed out changeset 8567e6595acc (bug 1826752)

cefd9267

Bug 1826756 - Make mfbt/tests/gtest buildable outside of a unified build environment r=andi · 26061f89
serge-sans-paille authored 1 year ago
```
Differential Revision: https://phabricator.services.mozilla.com/D174881
```
26061f89

Apr 12, 2023
- no bug - mfbt: use the C++ usual declaration r=andi DONTBUILD · fd7fdbcc
  Sylvestre Ledru authored 1 year ago
  
  Depends on D174439 Differential Revision: https://phabricator.services.mozilla.com/D174440
  fd7fdbcc
Mar 27, 2023
- Bug 1276351 - remove unused mozilla::tuple. r=sergesanspaille · 02db5a8d
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173299
  02db5a8d
Mar 25, 2023

Backed out 2 changesets (bug 1276351) for causing build bustage in... · 9db345d4

Sandor Molnar authored 1 year ago

Backed out 2 changesets (bug 1276351) for causing build bustage in image/ClippedImage.cp CLOSED TREE

Backed out changeset e84598eb82c1 (bug 1276351)
Backed out changeset e940b0554484 (bug 1276351)

9db345d4

Bug 1276351 - remove unused mozilla::tuple. r=sergesanspaille · 770e8dca
Andi-Bogdan Postelnicu authored 1 year ago
```
Differential Revision: https://phabricator.services.mozilla.com/D173299
```
770e8dca

Mar 24, 2023
- Backed out 2 changesets (bug 1276351) for causing multiple failures. · 6d40eee9
  Iulian Moraru authored 1 year ago
  
  Backed out changeset eeaf4f1e06af (bug 1276351) Backed out changeset d44cb5704342 (bug 1276351)
  6d40eee9
- Bug 1276351 - remove unused mozilla::tuple. r=sergesanspaille · 90401e3f
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173299
  90401e3f
Mar 22, 2023
- Bug 1660405 - remove unused mozilla::IsFinite. r=sergesanspaille · e6c033fe
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173050
  e6c033fe
- Bug 1660405 - remove unused mozilla::IsInfinite. r=sergesanspaille · c4666f21
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173049
  c4666f21
- Bug 1660405 - remove unused mozilla::IsNaN. r=sergesanspaille · 847a0f9d
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173048
  847a0f9d
- Backed out 7 changesets (bug 1660405) for causing bustages on Linux x64 opt. CLOSED TREE · e31a1780
  Stanca Serban authored 1 year ago
  
  Backed out changeset ad1a5f59214f (bug 1660405) Backed out changeset a39e95f0aafe (bug 1660405) Backed out changeset 48629ee0d70d (bug 1660405) Backed out changeset 8419b99aab60 (bug 1660405) Backed out changeset 535cc12c8bed (bug 1660405) Backed out changeset e27052da4927 (bug 1660405) Backed out changeset 11b0f9cf8091 (bug 1660405)
  e31a1780
- Bug 1660405 - remove unused mozilla::IsFinite. r=sergesanspaille · 76fde739
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173050
  76fde739
- Bug 1660405 - remove unused mozilla::IsInfinite. r=sergesanspaille · ffa4c727
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173049
  ffa4c727
- Bug 1660405 - remove unused mozilla::IsNaN. r=sergesanspaille · c2d0ffba
  Andi-Bogdan Postelnicu authored 1 year ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D173048
  c2d0ffba
Mar 13, 2023
- Bug 1799258 - span_iterator::difference_type s/index_type/ptrdiff/. r=bradwerth · 19eabfaf
  Kelsey Gilbert authored 2 years ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D167473
  19eabfaf
Feb 15, 2023

Backed out 9 changesets (bug 1799258) for causing multiple failures. CLOSED TREE · aaea911d

Stanca Serban authored 2 years ago

Backed out changeset 40351b5987a5 (bug 1799258)
Backed out changeset 87f3532bfbcd (bug 1799258)
Backed out changeset 9c1d9405e8bf (bug 1799258)
Backed out changeset 60a0351d9092 (bug 1799258)
Backed out changeset 5f911de66ec0 (bug 1799258)
Backed out changeset 294a00d1c7b7 (bug 1799258)
Backed out changeset 228200dcaf93 (bug 1799258)
Backed out changeset b25110652394 (bug 1799258)
Backed out changeset 3c3c7366cc40 (bug 1799258)

aaea911d

Bug 1799258 - span_iterator::difference_type s/index_type/ptrdiff/. r=bradwerth · 0c259e6b
Kelsey Gilbert authored 2 years ago
```
Differential Revision: https://phabricator.services.mozilla.com/D167473
```
0c259e6b

Feb 13, 2023

Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium · d7e8a09c

Andi-Bogdan Postelnicu authored 2 years ago

Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D168658

d7e8a09c

Feb 06, 2023

Backed out 9 changesets (bug 1799258) for causing build bustages CLOSED TREE · ed1015da

Norisz Fay authored 2 years ago

Backed out changeset a48db1421c6d (bug 1799258)
Backed out changeset 7707637480e7 (bug 1799258)
Backed out changeset 0141b29bf5df (bug 1799258)
Backed out changeset cd9af26bb314 (bug 1799258)
Backed out changeset 4e68a54c6410 (bug 1799258)
Backed out changeset 52afd24d2338 (bug 1799258)
Backed out changeset b4b4977857c7 (bug 1799258)
Backed out changeset 2c23929f52f2 (bug 1799258)
Backed out changeset 83744e1e372b (bug 1799258)

ed1015da

Bug 1799258 - span_iterator::difference_type s/index_type/ptrdiff/. r=bradwerth · 847d649f
Kelsey Gilbert authored 2 years ago
```
Differential Revision: https://phabricator.services.mozilla.com/D167473
```
847d649f

Feb 01, 2023

Bug 646323 - Rewrite mfbt/Casting.h assertion in modern style, and teach it to... · e6efd6d0

Paul Adenot authored 2 years ago

Bug 646323 - Rewrite mfbt/Casting.h assertion in modern style, and teach it to deal with floating point values. r=kinetik

This now uses `if constexpr (...)` which is a lot more readable, and still
compiles to almost no assembly instructions, as expected.

Floating point casting assert when casting an integer that's too large to be
represented exactly as a floating point (e.g. UINT64_MAX to double, since double
have less than 64 bytes of mantissa), or when casting a double that's too large
to be represented in a float.

Differential Revision: https://phabricator.services.mozilla.com/D167955

e6efd6d0

Backed out changeset 39cfeb7cffda (bug 646323) for causing bustages in Casting.h. CLOSED TREE · 0758dd98
Stanca Serban authored 2 years ago

0758dd98

Bug 646323 - Rewrite mfbt/Casting.h assertion in modern style, and teach it to... · 65406dde

Paul Adenot authored 2 years ago

Bug 646323 - Rewrite mfbt/Casting.h assertion in modern style, and teach it to deal with floating point values. r=kinetik

This now uses `if constexpr (...)` which is a lot more readable, and still
compiles to almost no assembly instructions, as expected.

Differential Revision: https://phabricator.services.mozilla.com/D167955

65406dde

Jan 24, 2023

Backed out 6 changesets (bug 1799258) for failures on... · f822f996

Csoregi Natalia authored 2 years ago

Backed out 6 changesets (bug 1799258) for failures on gfx.color_management.display_profile. CLOSED TREE

Backed out changeset 22351f36b74b (bug 1799258)
Backed out changeset 9bbbe3ed2794 (bug 1799258)
Backed out changeset e05c809f58d0 (bug 1799258)
Backed out changeset 791eeb52f034 (bug 1799258)
Backed out changeset 353ef4721bba (bug 1799258)
Backed out changeset b5157d950aa7 (bug 1799258)

f822f996

Jan 23, 2023
- Bug 1799258 - span_iterator::difference_type s/index_type/ptrdiff/. r=bradwerth · c0f7411f
  Kelsey Gilbert authored 2 years ago
  
  Differential Revision: https://phabricator.services.mozilla.com/D167473
  c0f7411f
Dec 20, 2022
- Bug 1806483 - Enable TSAN cppunittests by default. r=jmaher · 0d7440e1
  Ryan VanderMeulen authored 2 years ago
  
  Depends on D164960 Differential Revision: https://phabricator.services.mozilla.com/D165059
  0d7440e1
Nov 16, 2022

Bug 1800293 - mfbt: Don't use std::is_literal_type when compiling as C++20. r=glandium · 9e50a890

Chris Peterson authored 2 years ago

`std::is_literal_type` was deprecated in C++17 and removed in C++20. Continue using it when compiling as C++17 to retain what benefits it does provide for generic code.

> The `is_literal` type trait offers negligible value to generic code, as what is really needed is the ability to know that a specific construction would produce constant initialization. The core term of a literal type having at least one constexpr constructor is too weak to be used meaningfully.

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html

https://en.cppreference.com/w/cpp/types/is_literal_type

Differential Revision: https://phabricator.services.mozilla.com/D161952

9e50a890

Sep 28, 2022

Bug 1783242 - Part 3: Remove BufferList::Extract, r=glandium,ipc-reviewers,mccr8 · 7210a4bc

Nika Layzell authored 2 years ago

The only uses of this method were removed in Part 1, meaning that it can
now be removed. Support for this method adds a significant amount of
complexity to `BufferList` and IPC serialization.

Differential Revision: https://phabricator.services.mozilla.com/D154439

7210a4bc

Sep 22, 2022

Bug 1788969 - Correct ForEach Tuple helper functions. r=glandium · bd1c6c4d
Peter Van der Beken authored 2 years ago
```
Differential Revision: https://phabricator.services.mozilla.com/D156322
```
bd1c6c4d

Backed out 11 changesets (bug 1788969, bug 1782400, bug 1777145) for causing... · 141cdeee

Sandor Molnar authored 2 years ago

Backed out 11 changesets (bug 1788969, bug 1782400, bug 1777145) for causing bp-hybri bustages. CLOSED TREE

Backed out changeset 8acabb924ef7 (bug 1782400)
Backed out changeset e3d452e99f77 (bug 1782400)
Backed out changeset 5727bc4895d2 (bug 1777145)
Backed out changeset cf375034e2b8 (bug 1777145)
Backed out changeset a50fd5608d8d (bug 1777145)
Backed out changeset f24853cacd7a (bug 1777145)
Backed out changeset c714f3a35b11 (bug 1777145)
Backed out changeset 56682c253427 (bug 1788969)
Backed out changeset edaf37ffc49d (bug 1788969)
Backed out changeset d19caa9f062b (bug 1788969)
Backed out changeset 18b26912dc03 (bug 1788969)

141cdeee

Bug 1788969 - Correct ForEach Tuple helper functions. r=glandium · 7650d454
Peter Van der Beken authored 2 years ago
```
Differential Revision: https://phabricator.services.mozilla.com/D156322
```
7650d454