Skip to content
Snippets Groups Projects
  1. Aug 16, 2011
  2. Aug 15, 2011
  3. Aug 14, 2011
  4. Aug 13, 2011
  5. Aug 14, 2011
    • Daniel Holbert's avatar
    • Marco Castelluccio's avatar
    • Ed Morley's avatar
      Bug 665532 - Fix unused variable warnings in nsWifiMonitor.cpp by removing now... · 68358935
      Ed Morley authored
      Bug 665532 - Fix unused variable warnings in nsWifiMonitor.cpp by removing now unneeded LOG()s; r=dougt
      68358935
    • L. David Baron's avatar
      Remove the multiple-parameter versions of nsRenderingContext::SetFont. (Bug... · b3f49b92
      L. David Baron authored
      Remove the multiple-parameter versions of nsRenderingContext::SetFont.  (Bug 678671, patch 5)  r=roc
      
      This changes the only remaining callers (in nsMathMLChar) to pass the
      correct language, which they were not previously doing, which should
      improve the correctness of font selection and also reduce the number of
      unique font metrics objects requested (which helps nsFontCache
      effectiveness).  Those callers, however, remain the odd font users
      within all of layout.
      b3f49b92
    • L. David Baron's avatar
      Remove nsPresContext::GetMetricsFor, which was always a bad idea since it uses... · fa63f6d2
      L. David Baron authored
      Remove nsPresContext::GetMetricsFor, which was always a bad idea since it uses the generally-incorrect language-from-charset.  (Bug 678671, patch 4)  r=roc
      
      This fixes the one remaining caller (the debugging code to visually
      display reflow counts!) to just pass a null language, since it's just
      debugging code.
      fa63f6d2
    • L. David Baron's avatar
      Make nsRuleNode's use of font metrics for ch and ex units pass the correct... · b47daece
      L. David Baron authored
      Make nsRuleNode's use of font metrics for ch and ex units pass the correct language.  (Bug 678671, patch 3)  r=roc
      
      This makes these users (which are exceptions within layout, although
      low-level enough that it won't matter for font inflation work) call
      through to GetMetricsFor explicitly with the correct language, rather
      than using the broken nsPresContext::GetMetricsFor and its
      charset-detected language.
      
      This improves the correctness of our behavior for 'ch' and 'ex' CSS
      units when the font selection (or defaults) are language-dependent.  It
      should also reduce the number of unique sets of font metrics requested
      (which helps nsFontCache effectiveness).
      b47daece
    • L. David Baron's avatar
      Replace all uses of nsLayoutUtils::SetFontFromStyle with... · 84b8b6bf
      L. David Baron authored
      Replace all uses of nsLayoutUtils::SetFontFromStyle with GetFontMetricsForFrame or GetFontMetricsForStyleContext and remove SetFontFromStyle.  (Bug 678671, patch 2)  r=roc
      
      There was nothing wrong with SetFontFromStyle, except that it's just one
      more API to think about (and one more API to audit and modify for font
      inflation work to happen in bug 627842).
      84b8b6bf
    • L. David Baron's avatar
      Switch lots of callers to using nsLayoutUtils::GetFontMetricsForFrame and... · d2b68912
      L. David Baron authored
      Switch lots of callers to using nsLayoutUtils::GetFontMetricsForFrame and nsLayoutUtils::GetFontMetricsForStyleContext.  (Bug 678671, patch 1)  r=roc
      
      This changes a number of callers that were previously bypassing the use
      of the correct language (with either no language or the charset-detected
      language on the pres context via nsPresContext::GetMetricsFor) and/or
      the correct user font set to pass the correct values, which should
      improve the correctness of the behavior of whatever they were using the
      fonts for, and also reduce the number of unique sets of font metrics
      requested (which helps nsFontCache effectiveness).
      d2b68912
  6. Aug 12, 2011
  7. Aug 11, 2011
  8. Aug 10, 2011
Loading