Skip to content
Snippets Groups Projects
  1. Jun 06, 2017
    • Alex Gaynor's avatar
      Bug 1367560 - Remove an assertion from the Directory constructor that the... · aa9f5488
      Alex Gaynor authored
      Bug 1367560 - Remove an assertion from the Directory constructor that the directory exists on disk from DEBUG builds; r=baku
      
      As long as Directory objects can be constructed in the content process, trying
      to access the file system conceptually does not make sense because of
      sandboxing. The canary in the coal mine for this was tests which started
      crashing on Directory construction as we further locked down read access in the
      sandbox.
      
      MozReview-Commit-ID: HZitALYpO5H
      
      --HG--
      extra : rebase_source : 1f7e0361e40e45a9c23d5d78bdcdc1696d44d298
      aa9f5488
    • Mike de Boer's avatar
      Bug 1367970 - when switching panels quickly, the auto-resize workaround can... · 221a21cb
      Mike de Boer authored
      Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts. r=Gijs
      
      MozReview-Commit-ID: CpQFjDDm2BR
      
      --HG--
      extra : rebase_source : 971fe451fc50ddde02842dfef38c1e8908c05620
      221a21cb
  2. May 30, 2017
    • milindl's avatar
      Bug 1368754 - fix consumers which wait for... · cc3623f4
      milindl authored
      Bug 1368754 - fix consumers which wait for `NodeHistoryDetailsChanged`/`NodeURIChanged` to be called to use node for new values, r=mak
      
      Updated time, access count and uri can be accessed using the node passed to the method.
      There is no need to access the other arguments, which contain the old values of the
      quantities changed.
      
      MozReview-Commit-ID: 3WEwAs8gQ0w
      
      --HG--
      extra : rebase_source : 4f6f8bb9d9747cb9cfacf0a5ee5ed58dfca41c0d
      cc3623f4
    • milindl's avatar
      Bug 1368754 - Change `NodeHistoryDetailsChanged` and `NodeURIChanged` to be... · 4371c9b5
      milindl authored
      Bug 1368754 - Change `NodeHistoryDetailsChanged` and `NodeURIChanged` to be called with old time,access count and uri, r=mak
      
      Update interface and all instances where the method is called
      to be called with the old values, since the new values are already
      there as a part of the node, and thus redundant.
      
      MozReview-Commit-ID: 5pcfJbg9tej
      
      --HG--
      extra : rebase_source : 4053523f466c3b1f77148376e1e93aa4bcb7e417
      4371c9b5
  3. Jun 06, 2017
  4. Jun 05, 2017
  5. Jun 06, 2017
  6. Jun 05, 2017
  7. May 26, 2017
  8. Jun 06, 2017
  9. Jun 05, 2017
  10. Jun 06, 2017
  11. Jun 02, 2017
    • Mike Hommey's avatar
      Bug 1369622 - Add a static_assert when no variadic argument is given to... · 05a36a13
      Mike Hommey authored
      Bug 1369622 - Add a static_assert when no variadic argument is given to MOZ_CRASH_UNSAFE_PRINTF. r=froydnj
      
      If MOZ_CRASH_UNSAFE_PRINTF is only given a format string, it means
      either arguments are missing, or MOZ_CRASH should be used instead.
      Hint at that with a static_assert.
      
      --HG--
      extra : rebase_source : 355c37deb8b007e61939a4c657e411d110e7bbe7
      05a36a13
    • Mike Hommey's avatar
      Bug 1369622 - Restore static asserts for lack of arguments on some macros. r=froydnj · e9c25fa4
      Mike Hommey authored
      Bug 1368932 removed MOZ_STATIC_ASSERT_VALID_ARG_COUNT because it didn't
      actually work for large numbers of arguments. But it was kind of useful
      for macros that expand to something broken when they are given no
      variadic argument at all.
      
      Now that we have a macro that doesn't require tricks to count empty
      arguments lists, however, we can use straightforward static_asserts
      instead of a generic macro, which has the side effect of providing more
      context in the error message.
      
      --HG--
      extra : rebase_source : 223f85c2c5cc7b3fa8c584b70bb084784fb5764a
      e9c25fa4
    • Mike Hommey's avatar
      Bug 1369622 - Use MOZ_ARG_COUNT instead of MOZ_PASTE_PREFIX_AND_ARG_COUNT. r=froydnj · 8914ace4
      Mike Hommey authored
      In a couple places, MOZ_PASTE_PREFIX_AND_ARG_COUNT is used to only count
      the number of arguments, we can now use MOZ_ARG_COUNT directly for that.
      
      --HG--
      extra : rebase_source : 1064e4cc231863dc4aff83ee6bc90d318b4be418
      8914ace4
    • Mike Hommey's avatar
      Bug 1369622 - Fix MOZ_FOR_EACH with an empty list. r=froydnj · 38a6de0f
      Mike Hommey authored
      I'm not sure how I tested MOZ_FOR_EACH in bug 1368932, but it turns out
      it doesn't work with an empty list, despite
      MOZ_PASTE_PREFIX_AND_ARG_COUNT now supporting 0 arguments.
      
      Macros can be tricky, and it ends up being easier to make things work
      cross-compiler with a separate macro that does the counting, and
      (re)building MOZ_PASTE_PREFIX_AND_ARG_COUNT on top of that. Then
      MOZ_FOR_EACH ends up working as expected with an empty list.
      
      So this adds a MOZ_ARG_COUNT macro that counts the number of variadic
      arguments it's given, and derives MOZ_PASTE_PREFIX_AND_ARG_COUNT from
      it.
      
      And this adds a testcase validating that MOZ_FOR_EACH works properly
      with an empty list as a result.
      
      --HG--
      extra : rebase_source : 309371d87bd1561fbd2153f44fc1256185045d23
      38a6de0f
  12. Jun 06, 2017
  13. Jun 05, 2017
  14. May 25, 2017
  15. Jun 05, 2017
  16. Mar 22, 2017
  17. Jun 06, 2017
  18. May 10, 2017
    • Johann Hofmann's avatar
      Bug 1362408 - Fix disabled back button opacity on OSX. r=dao · a0e529b3
      Johann Hofmann authored
      On OSX, we want to not fade the entire back button when it is
      inactive. Instead we only fade the arrow icon. For that,
      we use the SVG context-fill-opacity property.
      
      MozReview-Commit-ID: J9I9BKHLedv
      
      --HG--
      extra : rebase_source : 8500a742d08d78e89f66bfc009fd54f59d2d2303
      a0e529b3
  19. Jun 06, 2017
  20. Jun 05, 2017
  21. Jun 04, 2017
  22. Jun 06, 2017
  23. Jun 05, 2017
  24. Jun 06, 2017
Loading