Bug 1824109 - [devtools] Make sure the paused task is resumed before exiting r=devtools-reviewers,nchevobbe a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D207088

Bug 1824109 - [devtools] Wait for SpecialPowers task to be resumed before leaving the test. r=devtools-reviewers,nchevobbe a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D198795

Bug 1865689 - Clarify access checks in devtools.inspectedWindow.eval r=rpl,devtools-reviewers,ochameau, a=dmeehan

and report a static error instead of including the URL in the message.

Differential Revision: https://phabricator.services.mozilla.com/D196133

Backed out changeset 18a676f4bf5d (bug 1865689)
Backed out changeset f1e03fbd5a76 (bug 1865689)

The individual test ran as expected when prefs was next to the file.
But when the whole directory is selected, the test runner refuses to
run the test due to the following error:

> The 'prefs' key must be set in the DEFAULT section of a manifest.

This patch fixes the issue by moving prefs to DEFAULT. This is okay
because the other test in the test manifest is independent of the pref.

Differential Revision: https://phabricator.services.mozilla.com/D196295

Bug 1865689 - Clarify access checks in devtools.inspectedWindow.eval r=rpl,devtools-reviewers,ochameau, a=dmeehan

and report a static error instead of including the URL in the message.

Differential Revision: https://phabricator.services.mozilla.com/D196133

Bug 1842197 - [devtools] Limit reads of devtools.inspector.ruleview.inline-compatibility-warning.enabled. r=devtools-reviewers,ochameau, a=pascalc

We already have a pref observer for the pref,
so we can store the pref value on the RuleView
instance and check this property instead of
using Services.prefs.

Differential Revision: https://phabricator.services.mozilla.com/D183001

Bug 1842197 - [devtools] Only read devtools.inspector.ruleview.inline-compatibility-warning.enabled once. r=devtools-reviewers,ochameau, a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D183000

Bug 1835930 - [devtools] Extend timeout for browser_net_har_multipage.js r=devtools-reviewers,nchevobbe a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D185290

Bug 1838671 - [devtools] Wrap decodeURI in try/catch block in SourcesTreeItem. r=bomsy,devtools-reviewers, a=dmeehan

The name of the source tree we want to decode might be malformed,
which can make decodeURI to throw.
A test case is added to ensure the issue is fixed.

Differential Revision: https://phabricator.services.mozilla.com/D181258

Bug 1838364 - [devtools] Show override for !important rules on the same inherited node r=devtools-reviewers,nchevobbe, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180921

Bug 1837185 - Correct remaining extension imports in devtools modules r=rpl,devtools-reviewers,jdescottes, a=dmeehan

Extension modules are singletons and must never be loaded through the
dedicated DevTools loader. This happens when --start-debugger-server is
used.

These files in question are primarily designed to support the Firefox
devtools, so I haven't created separate unit tests for these cases.
The kind of problem associated with this import pattern has been covered
by other patches in this bug.

Differential Revision: https://phabricator.services.mozilla.com/D180293

Bug 1837185 - Correct loader for extension imports in WebExtension descriptor +tests r=rpl,devtools-reviewers,jdescottes, a=dmeehan

The WebExtensionDescriptorActor loaded extension modules with the
dedicated devtools loader, which returns a different instance than
the real module in the browser. Besides the code not being designed to
be loaded twice in the same browser instance, this has the following
devtools-protocol-observable consequences:

- Uninitialized AddonManager -> Unable to detect addon updates/uninstalls.
- Detached ExtensionParent -> Unable to observe the actual extension,
  including not seeing extension state such as warnings.

Differential Revision: https://phabricator.services.mozilla.com/D180292

Bug 1837185 - Use realistic loader in test_webext_apis.js + fix failures r=devtools-reviewers,jdescottes, a=dmeehan

listAddons was broken because webbrowser.js imported AddonManager
through the wrong loader. Consequently, a new instance of the
AddonManager module was loaded, instead of the alreaady-initialized one
from the browser. This lead to the observed bug in the report.

test_webext_apis.js was not realistic because it did not use a dedicated
loader like DevToolsStartup. That prevented the test from catching the
regression. This patch fixes that by replicating the logic at
https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/devtools/startup/DevToolsStartup.sys.mjs#1075-1101

Differential Revision: https://phabricator.services.mozilla.com/D180253

Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179890

Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski

This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874

Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis

Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820

Bug 1835990 - [devtools] Don't release underlying object actor on ObjectInspector unmount for debugger tooltip. r=devtools-reviewers,bomsy.

The ObjectInspector releases actors on unmount to avoid
consuming memory, but this introduces unwanted behavior
in the Debugger tooltip as the tooltip can be hidden and
shown again, with the same underlying Object front.
In such case, you were not able to expand any of the
properties anymore, which is very frustrating.
To prevent this, we add a new prop to the ObjectInspector
to drive the auto release of the object actor, and we set
it to false for the tooltip ObjectInspector.
A test case is added to ensure we don't regress this.

Differential Revision: https://phabricator.services.mozilla.com/D179703

Bug 1772879 - [devtools] Remove useless memoization of getSourcesTabs selector. r=devtools-reviewers,jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D179677

Bug 1772879 - [devtools] Correctly memoize getSelectedSourceExceptions selectors. r=devtools-reviewers,jdescottes

createSelector argument was wrong and weren't doing shallow equal.

Differential Revision: https://phabricator.services.mozilla.com/D179676

Now it supports "normal" keyword. Also, offset-position doesn't create
stacking context and it doesn't have offset transform, so we can
simplify CompareMotionValues() a little bit.

Note: We don't have to add test in [1] because Blink added one to WPT
upstream repo already.

[1] css/motion/parsing/offset-position-parsing-valid.html

Note: the usage of offset-position is in other bugs.

Differential Revision: https://phabricator.services.mozilla.com/D179623

Bug 1834453 - [devtools] Add documentation for the sourcemaps ignore list r=devtools-reviewers,ochameau

Differential Revision: https://phabricator.services.mozilla.com/D179317

- Rename the general section to `ignoring sources`
- Update the image for the ignore a source section
- Added content and images for ignore line and ignore lines

Differential Revision: https://phabricator.services.mozilla.com/D179316

Bug 1836251 - [devtools] Always pass real location object to getBreakpoint. r=devtools-reviewers,bomsy

Differential Revision: https://phabricator.services.mozilla.com/D178396

Bug 1836251 - [devtools] Always pass real location object to continueToHere. r=devtools-reviewers,bomsy

Differential Revision: https://phabricator.services.mozilla.com/D178395

Bug 1836251 - [devtools] Always pass real location object for conditional panel. r=devtools-reviewers,bomsy

Differential Revision: https://phabricator.services.mozilla.com/D178394

Bug 1835680 - [devtools] Use proxy target when walking up prototype chain for autocomplete. r=devtools-reviewers,jdescottes.

In the JSPropertyProvider, we are walking up the prototype to retrieve properties.
For proxies with `getPrototypeOf` trap, this means that we were returning erroneous
values, as the prototype chain of the proxy isn't altered by the trap.
Worse, it could lead to infinite loop if the trap was setting a circular reference.

To avoid this, when dealing with a proxy, we retrieve the prototype of the proxy
target.

Test cases are added to ensure we don't regress this.

Differential Revision: https://phabricator.services.mozilla.com/D179640

Bug 1833656 - [devtools] Use real context menu item to save as HAR from har mochitests r=bomsy,devtools-reviewers

Depends on D178336

Differential Revision: https://phabricator.services.mozilla.com/D178337

Bug 1833656 - [devtools] Support multiple pages in HAR with filtered requests r=bomsy,ochameau,devtools-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D178336

1) Lets only load the `BlackboxLines` component when
- The selected source is on the ignore list
- The source is wholly or partially blackboxed

2) `BlackboxLines` should not longer be a connected component, lets pass the
values down from the parent.

This should fix the prefomance regression in Bug 1832019

Differential Revision: https://phabricator.services.mozilla.com/D179426

Backed out changeset 2f0f9d27fb0d (bug 1835680) for causing mochitests failures in test_jsterm_autocomplete.html. CLOSED TREE

Bug 1835680 - [devtools] Use proxy target when walking up prototype chain for autocomplete. r=devtools-reviewers,jdescottes.

In the JSPropertyProvider, we are walking up the prototype to retrieve properties.
For proxies with `getPrototypeOf` trap, this means that we were returning erroneous
values, as the prototype chain of the proxy isn't altered by the trap.
Worse, it could lead to infinite loop if the trap was setting a circular reference.

To avoid this, when dealing with a proxy, we retrieve the prototype of the proxy
target.

Test cases are added to ensure we don't regress this.

Differential Revision: https://phabricator.services.mozilla.com/D179640

Backed out 2 changesets (bug 1833656) for HAR related mochitests failures in browser_ext_devtools_network.js. CLOSED TREE

Backed out changeset bbafcf23c9dd (bug 1833656)
Backed out changeset b3c9e8328a9f (bug 1833656)

Bug 1833656 - [devtools] Use real context menu item to save as HAR from har mochitests r=bomsy,devtools-reviewers

Depends on D178336

Differential Revision: https://phabricator.services.mozilla.com/D178337

Bug 1833656 - [devtools] Support multiple pages in HAR with filtered requests r=bomsy,ochameau,devtools-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D178336

Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato

Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005

Bug 1704521 - [devtools] Add a preference to disable the F12 shortcut r=devtools-reviewers,fluent-reviewers,nchevobbe,flod

Depends on D143835

Differential Revision: https://phabricator.services.mozilla.com/D179463