Skip to content
Snippets Groups Projects
  1. Jul 04, 2023
    • Nika Layzell's avatar
      Bug 1841660 - Fix potential deadlock waiting for StartupCache ThreadedPrefetch, r=jesup a=RyanVM · 645fce5d
      Nika Layzell authored
      In a previous change to this logic, we missed a hidden early return in
      the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
      Linux and Windows. If this is hit, we could end up blocking at various
      points waiting for the StartupCache to be prefetched.
      
      This patch changes the logic to notify to happen in a ScopeExit instead,
      ensuring that it'll happen on all return paths.
      
      In addition, there was another potential deadlock due to the
      ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
      in the pointers in the runnable instead. This should be OK as we are
      making sure to block on ThreadedPrefetch before we clear the startup
      data already.
      
      Differential Revision: https://phabricator.services.mozilla.com/D182732
      645fce5d
  2. May 20, 2023
  3. May 17, 2023
  4. Apr 22, 2023
  5. Feb 19, 2023
  6. Feb 17, 2023
  7. Dec 01, 2022
  8. Oct 19, 2022
  9. Sep 15, 2022
  10. Aug 03, 2022
  11. Aug 02, 2022
  12. Jul 30, 2022
    • Nika Layzell's avatar
      Bug 1772006 - Part 4: Simplify and move the string comparison APIs from... · 997047e2
      Nika Layzell authored
      Bug 1772006 - Part 4: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
      
      This patch moves EqualsIgnoreCase to ns[T]StringObsolete, and removes
      the aCount argument, instead migrating callers to use `StringBeginsWith`
      with a case-insensitive comparator.
      
      In addition, nsTStringRepr::Compare was removed and replaced with either
      calls to methods like `StringBeginsWith` or the global `Compare` method.
      
      These changes required some modifications at call-sites but should make
      the behaviour less surprising and more consistent.
      
      Differential Revision: https://phabricator.services.mozilla.com/D148299
      997047e2
  13. Jul 12, 2022
  14. Jul 11, 2022
  15. Jun 10, 2022
    • criss's avatar
      Backed out 9 changesets (bug 1772006) causing build bustages on nsTString.cpp. CLOSED TREE · c6b2c5db
      criss authored
      Backed out changeset f17c7565707b (bug 1772006)
      Backed out changeset c725fe1f5882 (bug 1772006)
      Backed out changeset d19663161261 (bug 1772006)
      Backed out changeset b6611ab002d9 (bug 1772006)
      Backed out changeset 790f42b64af9 (bug 1772006)
      Backed out changeset 79a734b4e4d9 (bug 1772006)
      Backed out changeset 42730aae16ea (bug 1772006)
      Backed out changeset b2542aef3054 (bug 1772006)
      Backed out changeset 962bfea4a309 (bug 1772006)
      c6b2c5db
    • Nika Layzell's avatar
      Bug 1772006 - Part 5: Simplify and move the string comparison APIs from... · 1475267b
      Nika Layzell authored
      Bug 1772006 - Part 5: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
      
      In addition to moving these methods to a more appropriate file, they were
      simplified to make them easier to maintain in the future.
      nsTStringRepr::Compare was extended to also work on char16_t strings, and the
      case insensitive and other options were removed as they aren't necessary. This
      required some changes to callers in the tree.
      
      The EqualsIgnoreCase method was also simplified by using `std::string_view`.
      
      Differential Revision: https://phabricator.services.mozilla.com/D148299
      1475267b
  16. Apr 13, 2022
  17. Apr 05, 2022
  18. Mar 22, 2022
  19. Mar 17, 2022
  20. Mar 16, 2022
  21. Feb 25, 2022
  22. Oct 06, 2021
  23. Oct 05, 2021
Loading