Bug 1796316 - Change the necko owner, update the peers' list, and update the list of the relevant necko team’s directories r=zeid,necko-reviewers,kershaw

Differential Revision: https://phabricator.services.mozilla.com/D159784

Bug 1797050 - Part 4 - Use `browser_specific_settings` instead of `applications` in remaining tests. r=rpl,application-update-reviewers,bytesized

Differential Revision: https://phabricator.services.mozilla.com/D160060

destructor() should really clean-up after setup(), not the
constructor(), since setup() can be called multiple times.

Differential Revision: https://phabricator.services.mozilla.com/D160332

Bug 1796901 - Clear realm incremental marking state at the start of GC rather than at the end r=jandem

GC can be aborted in several states and zones GCRuntime::finishCollection
doesn't always get called. It's easier to clear this state in a signle place at
the start.

Differential Revision: https://phabricator.services.mozilla.com/D160056

Differential Revision: https://phabricator.services.mozilla.com/D160348

Differential Revision: https://phabricator.services.mozilla.com/D155457

Differential Revision: https://phabricator.services.mozilla.com/D160304

Bug 1795880 - Add an ESLint rule to enforce using static imports where possible. r=arai,geckoview-reviewers,m_kato

Differential Revision: https://phabricator.services.mozilla.com/D160131

Bug 1797454 - update meta data which links Firefox Settings UI files to their Bugzilla component. r=Gijs,preferences-reviewers DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D160335

Backed out changeset d076c8363b14 (bug 1743878) for causing bc failures on browser_findbar_disabled_manual.js. CLOSED TREE

The workflow for the toolchains project branch is that it's going to be
synchronized with mozilla-central, and each push is expected to trigger
new builds of the current (at the time of the push) clang upstream
trunk. If the tip of mozilla-central happens to have DONTBUILD, we still
want everything to start up.

Differential Revision: https://phabricator.services.mozilla.com/D160314

no bug - fix some typos found by codespell r=linter-reviewers,fluent-reviewers,Gijs,Standard8 DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D160290

Differential Revision: https://phabricator.services.mozilla.com/D160328

Differential Revision: https://phabricator.services.mozilla.com/D159691

Differential Revision: https://phabricator.services.mozilla.com/D159326

Differential Revision: https://phabricator.services.mozilla.com/D160044

Differential Revision: https://phabricator.services.mozilla.com/D160024

Bug 1795322 - Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu

Differential Revision: https://phabricator.services.mozilla.com/D160036

Bug 1795322 - Update toolkit modules references in testing code r=gbrown,webdriver-reviewers,whimboo

Differential Revision: https://phabricator.services.mozilla.com/D160035

Differential Revision: https://phabricator.services.mozilla.com/D160034

Differential Revision: https://phabricator.services.mozilla.com/D160033

Differential Revision: https://phabricator.services.mozilla.com/D160032

Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D160031

Differential Revision: https://phabricator.services.mozilla.com/D160030

Differential Revision: https://phabricator.services.mozilla.com/D160029

Bug 1795322 - Update toolkit modules references in update code. r=application-update-reviewers,bytesized

Differential Revision: https://phabricator.services.mozilla.com/D160028

Differential Revision: https://phabricator.services.mozilla.com/D160027

Bug 1795322 - Update toolkit modules references in marionette related code. r=whimboo,webdriver-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D160026

Differential Revision: https://phabricator.services.mozilla.com/D160025

Bug 1778999 - Remove backward compatible code for Services.jsm from httpd.js. r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D160327

Differential Revision: https://phabricator.services.mozilla.com/D159309

`AppUpdater.stop()` is not currently well tested, and the new implementation relies on throwing exceptions. It's important that these exceptions be properly caught to ensure that we don't end up handling the exception as an internal error or not handling it properly at all.

Differential Revision: https://phabricator.services.mozilla.com/D159308

Differential Revision: https://phabricator.services.mozilla.com/D159307

Differential Revision: https://phabricator.services.mozilla.com/D159306

We should be careful about calling `cleanupDownloadingUpdate`. We currently call it sometimes when `AUS.downloadUpdate` fails without checking whether we are already downloading an update. We don't want to mess up a download that is already in-progress just because a subsequent call to `downloadUpdate` failed.

It may have been necessary in the past to clean up if `downloadUpdate` failed in order to prevent leaving bits of downloading update state around. But now we don't set that state until the download has actually started, so some of those cleanup instances just aren't necessary anymore. We only really need to clean up if we might be resuming a download, in which case those bits of state will be lying around and ought to be cleaned up on failure.

Differential Revision: https://phabricator.services.mozilla.com/D159305

The Update Service stores information about the current update state in the status file and in the state properties of both downloadingUpdate and readyUpdate. It's important that we log changes to this information in order to better be able to debug tests and user issues.

Differential Revision: https://phabricator.services.mozilla.com/D159304

Also change some of the implementation of UpdateService to use the new currentState API.

This patch also fixes and cleans up a few things that are only tangentially related. Most notably, `_postUpdateProcessing` does a better job of handling the situation where Firefox starts while updating/staging is still in-progress. And `refreshUpdateStatus` does a better job of handling unexpected error situations like the updater binary crashing.

Differential Revision: https://phabricator.services.mozilla.com/D159303

Note that, for the most part, this isn't meant to change behavior. It is just meant to eliminate race conditions and fix some bugs. However, a tiny bit of behavior has been changed.

Previously, the fallback error codes used to potentially populate nsIUpdate.statusText were 200 in Checker.onError (corresponding to "Update XML file malformed") and 404 in Checker.onLoad (corresponding to "Update XML file not found"). These really seem backwards to me. Especially in the Checker.onLoad case, where we basically use that as the fallback if we fail to parse the update XML. So the codes have effectively been reversed in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D159302

Differential Revision: https://phabricator.services.mozilla.com/D159301

Differential Revision: https://phabricator.services.mozilla.com/D159300