Skip to content
Snippets Groups Projects
  1. Nov 15, 2017
  2. Nov 14, 2017
  3. Nov 13, 2017
    • Eitan Isaacson's avatar
    • Ya-Chieh Wu's avatar
      Bug 1381153 - Part 2: Look up MayHaveTransformAnimation in nsIFrame. r=mstange · cc97d127
      Ya-Chieh Wu authored
      Find out where we use MayHaveTransformAnimation in EffectSet
      and change them to MayHaveTransformAnimation in nsIFrame.
      
      MozReview-Commit-ID: GhkztK8JtNa
      cc97d127
    • Ya-Chieh Wu's avatar
      Bug 1381153 - Part 1: Cache MayHaveOpacityAnimation and... · d2e5bc76
      Ya-Chieh Wu authored
      Bug 1381153 - Part 1: Cache MayHaveOpacityAnimation and MayHaveTransformAnimation in nsIFrame. r=mstange, r=mats
      
      There are two places where I have to cache the status of MayHaveOpacityAnimation
      and MayHaveTransformAnimation. First place is in |nsIFrame:init()| where an
      element is associated with a frame. Second place is in
      |KeyframeEffectReadOnly::UpdateEffectSet()| where the script can add animations
      on element.
      
      btw I keep the original two flags of MayHaveOpacityAnimation and
      MayHaveTransformAnimation in EffectSet because there is no guarantee that
      an element has been associated with a frame when we call to |UpdateEffectSet()|.
      But we still want to keep the benefits that we can quickly look up
      MayHaveOpacityAnimation or MayHaveTransformAnimation. So I keep them in
      EffectSet and transfer the status into nsIFrame when we bind an element
      to a frame in nsIFrame:Init().
      
      MozReview-Commit-ID: JDwyAQQTKA7
      d2e5bc76
  4. Nov 02, 2017
    • Blake Kaplan's avatar
      Bug 1389836 - Push extensions from MIME info objects to the child. r=bz · 47a7f171
      Blake Kaplan authored
      It would be really nice to push all of this back up to the parent or to at
      least make it asynchronous. I think it should be possible since we control
      when we send the DOM events, but for the moment this should work.
      
      With this patch, I extend ProxyMIMEInfo and HandlerInfo with information about
      the available extensions for a given MIME type. On Linux, at least, we read
      the system (in my case GNOME) registry in the child and handlers.json in the
      parent finally merging them again in the child (in
      ContentHandlerService::FillHandlerInfo). Even though I was unable to get my
      mochitest to work, it did work well enough that I could verify that this patch
      was getting all of the proper extensions to the nsContentAreaDragDrop.cpp
      code.
      
      MozReview-Commit-ID: AR3VayMUiDN
      
      --HG--
      extra : rebase_source : f9861e46e92fb7e8d297eff3e5d61a3c18912b47
      47a7f171
  5. Oct 25, 2017
  6. Nov 13, 2017
  7. Nov 15, 2017
  8. Nov 13, 2017
  9. Nov 08, 2017
  10. Nov 14, 2017
    • Tom Ritter's avatar
      Bug 1414067 Fix the compiler test for FORTIFY_SOURCE r=glandium · d86bb6f5
      Tom Ritter authored
      MozReview-Commit-ID: 8ozY0Zbuczx
      
      --HG--
      extra : rebase_source : 7c99ea332b0da1ac20ec1037fb0dc4ac9088d8f8
      d86bb6f5
    • Mike Hommey's avatar
      Bug 1417234 - Use SRWLock as Mutex for mozjemalloc on Windows. r=njn · 1f75d81c
      Mike Hommey authored
      SRWLock is more lightweight than CriticalSection, but is only available
      on Windows Vista and more. So until we actually dropped support Windows
      XP, we had to use CriticalSection.
      
      Now that all supported Windows versions do have SRWLock, this is a
      switch we can make, and not only because SRWLock is more lightweight,
      but because it can be statically initialized like on other platforms,
      allowing to use the same initialization code as on other platforms,
      and removing the requirement for a DllMain, which in turn can allow
      to statically link mozjemalloc in some cases, instead of requiring a
      shared library (DllMain only works on shared libraries), or manually
      call the initialization function soon enough.
      
      There is a downside, though: SRWLock, as opposed to CriticalSection, is
      not fair, meaning it can have thread scheduling implications, and can
      theoretically increase latency on some threads. However, it is the
      default used by Rust Mutex, meaning it's at least good enough there.
      Let's see how things go with this.
      
      --HG--
      extra : rebase_source : 337dc4e245e461fd0ea23a2b6b53981346a545c6
      1f75d81c
  11. Nov 07, 2017
  12. Nov 14, 2017
    • Chris Manchester's avatar
      Bug 1416490 - Backed out changeset 6a412222f22e (bug 1320738) in favor of... · 0ae43c13
      Chris Manchester authored
      Bug 1416490 - Backed out changeset 6a412222f22e (bug 1320738) in favor of fixing the underlying issue. r=glandium
      
      MozReview-Commit-ID: 5JaoquWq5Jj
      
      --HG--
      extra : rebase_source : 70f3cff23ab7d4d0f0e79d1cf207b0462c355ce0
      0ae43c13
    • Chris Manchester's avatar
      Bug 1416490 - Ensure environment variables that are configure options are... · 8055730c
      Chris Manchester authored
      Bug 1416490 - Ensure environment variables that are configure options are passed from configure to old-configure. r=glandium
      
      
      MozReview-Commit-ID: GFP8bahu1bb
      
      --HG--
      extra : rebase_source : 1ff35a8b6470308b71dc74c2befb8219a41534c2
      8055730c
    • Chris Manchester's avatar
      Bug 1416490 - Check for a value passed to RUSTC_OPT_LEVEL rather than whether... · 2473770f
      Chris Manchester authored
      Bug 1416490 - Check for a value passed to RUSTC_OPT_LEVEL rather than whether its value was a default. r=glandium
      
      The current code will fail if "RUSTC_OPT_LEVEL=" is passed. This can happen
      if the value isn't present and that fact is injected into js' configure. We
      only want to respect RUSTC_OPT_LEVEL if a value is passed, so we simply check
      for the presence of a value rather than its origin.
      
      MozReview-Commit-ID: 6GhLfprJEEn
      
      --HG--
      extra : rebase_source : 40f3e381a128e04d65cc0175df32cdcd8302e05e
      2473770f
    • Makoto Kato's avatar
      Bug 1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly. r=jfkthame · 71764642
      Makoto Kato authored
      On Windows 7, there is yy/mm/dd'('ddd')' as short date format of Japanese.
      When selecting this, ddd isn't converted to day of the week correctly.
      
      FindInReadable will update start position iterator even if not found. So when
      using FindInReadable again, we have to reset start position iterator.
      
      MozReview-Commit-ID: AoS1Txq3Twc
      
      --HG--
      extra : rebase_source : 2f02189d0288e833debb2d4ca47efbca632924e5
      71764642
  13. Nov 15, 2017
  14. Nov 10, 2017
    • Gregory Szorc's avatar
      Bug 1416052 - Remove OBJDIR_TARGETS; r=nalexander · fd8c5314
      Gregory Szorc authored
      Now that we require mach to run client.mk and mach only invokes
      client.mk for full builds (the "build" target) and configure
      (the "configure" target), we should no longer have anyone using
      client.mk as a proxy to make targets in the build backend.
      
      So remove that feature.
      
      MozReview-Commit-ID: BbaMdZHnRXy
      
      --HG--
      extra : rebase_source : 570e81a62e35cbe4ea27e011883a306f23f3024c
      fd8c5314
    • Gregory Szorc's avatar
      Bug 1416052 - Remove build_and_deploy target; r=nalexander · 10cdc197
      Gregory Szorc authored
      This was added before mach AFAICT. If people need this functionality,
      we can add a mach command.
      
      MozReview-Commit-ID: HL52nJE2SMQ
      
      --HG--
      extra : rebase_source : cdf67a997731e7f1f94e16aa36c3f806c09779e8
      10cdc197
    • Gregory Szorc's avatar
      Bug 1416052 - Check clobber state from Python; r=nalexander · 2f56664d
      Gregory Szorc authored
      The clobber logic is already written in Python. Now that we
      always use mach in front of client.mk, we can check the clobber
      state before we execute client.mk.
      
      Since we always check the clobber state, we can remove the
      CLOBBER files from various dependencies in client.mk. The
      clobberer code should ensure everything is in a good state.
      
      The refactor of the clobber Python code required some changes to
      its testing. We drop some support for verifying output strings.
      But testing this correctly would require a bit of effort. I don't
      think it is worth it.
      
      MozReview-Commit-ID: 69CoImCgtNm
      
      --HG--
      extra : rebase_source : c925bb49fd54fe6a5abaa4ac9dc0833e139c6a57
      2f56664d
    • Gregory Szorc's avatar
      Bug 1416052 - Remove reference to undefined BUILD_PROJECT_ARG; r=nalexander · ad52bc48
      Gregory Szorc authored
      I'm pretty sure this was related to the now removed feature for
      building multiple projects.
      
      MozReview-Commit-ID: 4AG7lsk6BLS
      
      --HG--
      extra : rebase_source : b677a141161255ffeea57358d4f497fc05c8fb1c
      ad52bc48
    • Gregory Szorc's avatar
      Bug 1416052 - Remove mkdir of objdir from client.mk; r=nalexander · 4c710821
      Gregory Szorc authored
      Now that mach is being used to invoke client.mk, we can perform
      objdir directory creation there.
      
      Removing the use of mkdir_deps meant that we could remove some
      included make files which AFAICT were only used to provide
      $(mkdir_deps).
      
      MozReview-Commit-ID: 4ZRToz8xqZy
      
      --HG--
      extra : rebase_source : 8d0d2430b33863e1dec8cee84e72178307d1c6e0
      extra : source : d223afd90123eba035714288d5da9394b2dbb8d8
      4c710821
    • Gregory Szorc's avatar
      Bug 1416052 - Remove comment filtering; r=nalexander · 1bddd821
      Gregory Szorc authored
      The auto-generated make file that we include (and the `mach environment`
      output that we included before that) should not contain comment lines.
      I think it is safe to remove the code that filters them out.
      
      It is possible a multi-line value in mozconfigs could contain lines
      looking like comments and this may cause problems. I'm inclined to
      believe that this scenario doesn't exist. If someone complains and
      we need to bring back support, we could certainly do that.
      
      MozReview-Commit-ID: 8kKw91HH4ms
      
      --HG--
      extra : rebase_source : 3fab8af7f713c91632f3d5172664832af10b555f
      1bddd821
    • Gregory Szorc's avatar
      Bug 1416052 - Move export of FOUND_MOZCONFIG to Python; r=nalexander · e4998a9e
      Gregory Szorc authored
      This should have the same net result.
      
      TBH, I'm not 100% convinced we need this export. It is only needed
      to send variables to sub-makes. And the only make file reading
      FOUND_MOZCONFIG is client.mk. Since the code that evals the
      auto-generated make file is always executed in client.mk, we
      shouldn't need this export.
      
      All this code is going away soon anyway. So I'm inclined to cargo
      cult this just in case.
      
      MozReview-Commit-ID: DqF1BU702A
      
      --HG--
      extra : rebase_source : 31859c0d4bb6ceb06367bf0ca554d79d57d2d0c3
      e4998a9e
    • Gregory Szorc's avatar
      Bug 1416052 - Generate a make file to include in client.mk; r=nalexander · 5da7c49f
      Gregory Szorc authored
      Currently, client.mk calls `mach environment` to obtain a make file
      to be evaluated in the context of client.mk. The reason it is
      implemented this way is because client.mk could be an entrypoint to
      the build system.
      
      With recent changes that require the use of mach to use client.mk,
      we are now guaranteed to have Python code running before client.mk
      is invoked. This means we don't need to invoke `mach` from client.mk.
      
      This commit ports the code for generating a client.mk suitable make
      file from `mach environment` to the build dispatcher. We now write out
      a new .mozconfig-client-mk file in the objdir. client.mk is changed
      to cat this file and to include it as a native make file.
      
      The OBJDIR environment variable is also set so client.mk knows where
      to read the auto-generated file from.
      
      This commit should be backwards compatible.
      
      Hopefully it is obvious, but this new make file is only temporary.
      As soon as the remaining mozconfig logic is moved out of client.mk,
      we should be able to simplify down to a single "include" in client.mk.
      
      MozReview-Commit-ID: BEfWo76Z1qA
      
      --HG--
      extra : rebase_source : 752df93f816b95bda108a3c787d7f4941b136bbb
      5da7c49f
    • Gregory Szorc's avatar
      Bug 1416052 - Remove references to MOZ_CURRENT_PROJECT; r=nalexander · 550570a1
      Gregory Szorc authored
      Actual uses of this variable were removed by 5fb427c50ca3
      (bug 1412431). This is dead code.
      
      MozReview-Commit-ID: GsDqpXZol2L
      
      --HG--
      extra : rebase_source : ce6eb799aa8a20e7a9af0587167bf05a6095b8df
      550570a1
Loading