Skip to content
Snippets Groups Projects
  1. Sep 17, 2019
  2. Sep 16, 2019
  3. Sep 17, 2019
  4. Sep 13, 2019
  5. Sep 17, 2019
  6. Sep 16, 2019
  7. Sep 17, 2019
    • Kershaw Chang's avatar
      Bug 1581105 - Add dom/fetch/tests/crashtests/crashtests.list r=baku · 7841491f
      Kershaw Chang authored
      Differential Revision: https://phabricator.services.mozilla.com/D45835
      
      --HG--
      extra : moz-landing-system : lando
      7841491f
    • Masayuki Nakano's avatar
      Bug 1540029 - part 2: Get rid of `TextEditRules::DocumentIsEmpty()` and... · db32271c
      Masayuki Nakano authored
      Bug 1540029 - part 2: Get rid of `TextEditRules::DocumentIsEmpty()` and `HTMLEditRules::DocumentIsEmpty()` r=m_kato
      
      `TextEditRules::DocumentIsEmpty()` is a wrapper of `TextEditor::IsEmpty()` so
      that we can get rid of it simply.
      
      `HTMLEditRules::DocumentIsEmpty()` needs to change.  It's oddly checks only
      `EditorBase::mPaddingBRElementForEmptyEditor` is `nullptr` or not.  However,
      the editor may be completely empty.  And the result may be different from
      `TextEditor::IsEmpty()` which is not overridden by `HTMLEditor`.  For partially
      solving this issue, this patch makes `HTMLEditor` overrides `IsEmpty()` and
      optimizes `TextEditor::IsEmpty()`.
      
      With this change, the caller of `HTMLEditRules::DocumentIsEmpty()` may behave
      differently in the only caller, `HTMLEditor::SelectEntireDocument()`.  And
      unfortunately, its root called from `SelectAllCommand::DoCommand()`.  However,
      it does just collapse `Selection` into the root element (`<body>` or
      `Document.documentElement`) if it returns `true`.  Therefore, this change
      must be safe since anyway `SelectionRefPtr()->SelectAllChildren()` with
      the root element is exactly same as `SelectionRefPtr()->Collapse()` with
      the empty root element if it's truly empty.
      
      Differential Revision: https://phabricator.services.mozilla.com/D45784
      
      --HG--
      extra : moz-landing-system : lando
      db32271c
  8. Sep 16, 2019
  9. Sep 17, 2019
  10. Sep 16, 2019
Loading