In days of old, it was safe to use -brand-short-name for this, as it always lined up with the installer's concept of BrandShortName. This changed when https://bugzilla.mozilla.org/show_bug.cgi?id=1378834 landed -- which started using "Firefox Nightly" for the nightly branding BrandShortName in the installer (but maintained "Nightly" as the in-product -brand-short-name). Changing one or the other of these is not really a viable option:

- Changing the installer's BrandShortName for Nightly to match -brand-short-name would cause shortcuts to simply be called "Nightly" -- which is the opposite of what the aforementioned bug wanted
- Changing -brand-short-name would cause a number of in-product strings to start using "Firefox Nightly" instead of "Nightly" -- which is probably undesirable for a few reasons, not the least of which is possible l10n implications

For these reasons, and the relatively short timeline I have to fix this, I'm taking the simplest and easiest path of introducing a new string specifically for in-product shortcut names, which lines up with the installer's values for BrandShortName. (We perhaps should also separate this out in the installer -- but it's unnecessary here, so I did not go to the trouble.)

Differential Revision: https://phabricator.services.mozilla.com/D156991

Differential Revision: https://phabricator.services.mozilla.com/D157051

Bug 1788601 - [devtools] Fix ESLint consistent-return failures in devtools/client/framework. r=ochameau.

Differential Revision: https://phabricator.services.mozilla.com/D156159

Bug 1788594 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/. r=bomsy.

Differential Revision: https://phabricator.services.mozilla.com/D156156

Backed out changeset 8de3f54dc3ca (bug 1781434) for causing mochitest failures on test_dialogfocus.xhtml . CLOSED TREE

Backed out changeset 09fd858a96c9 (bug 1783497) for causing Xpcshell failures on test_ext_cookies_partitionKey.js

Bug 1789883 - Add telemetry to know often users click in the secondary toolbar r=TravisLong,pdfjs-reviewers,marco

Differential Revision: https://phabricator.services.mozilla.com/D157114

We had zero tests for this, and when I implemented the optimization to
avoid reframing in most cases I apparently swapped the arguments ;_;

Fix <input type=search> which suffered from the same issue, but we don't
ship by default.

Differential Revision: https://phabricator.services.mozilla.com/D155394

The default constructor for RemoteImageHolder assigns default values to
all of its members. gfx::ColorDepth does not define a default value. This
change makes it so RemoteImageHolder provides a default value.

Differential Revision: https://phabricator.services.mozilla.com/D157128

When D155902 merged and landed, it undid a recent change in
RemoteVideoDecoderParent::ProcessDecodedData without causing a compiler
error. This fixes up the merge to what was intended.

Differential Revision: https://phabricator.services.mozilla.com/D157080

Make it a bit easier to read and less prone to race conditions. Remove a
setTimeout referencing bug 103197 which I'm pretty sure it's not an
issue.

Differential Revision: https://phabricator.services.mozilla.com/D156543

Drive-by, but this should be more correct, since I'm not sure how this
code would handle mSVGView otherwise, which is in effect on the relevant
page.

Differential Revision: https://phabricator.services.mozilla.com/D157022

Backed out changeset aeb32fa2f7d5 (bug 1761089) for causing failures on IPCBlobUtils.cpp. CLOSED TREE

Looks like this is not needed and making a web-compat issue.

Differential Revision: https://phabricator.services.mozilla.com/D156985

Differential Revision: https://phabricator.services.mozilla.com/D157058

This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156426

Bug 1479515 - Extend the ESLint rule for checking Ci properties to check for unknown interfaces as well. r=Gijs,application-update-reviewers,nalexander

Differential Revision: https://phabricator.services.mozilla.com/D156425

This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156424

ReflowChildren() only cares about the flex item's normal position, so we don't
need to output the relative position from `MoveFlexItemToFinalPosition()`.

By making `aFramePos` const for `MoveFlexItemToFinalPosition`, we can delete
`itemNormalBPos` because `framePos` cannot be changed after calling
`MoveFlexItemToFinalPosition`.

This patch shouldn't change the behavior.

Differential Revision: https://phabricator.services.mozilla.com/D157079

`aFramePos` is never modified in ReflowFlexItem().

Differential Revision: https://phabricator.services.mozilla.com/D157078

This was previously disabled in bug 1673194 because of start up crashes.
It seems like msmpeg2vdec.dll may use dynamic code to support encrypted
code that uses. In recent versions of Windows this only seems used
in the 32bit version. The 32bit version will opt out of ACG on the
threads where it needs to use VirtualProtect so we use the weaker
variant there.

Differential Revision: https://phabricator.services.mozilla.com/D153762

Differential Revision: https://phabricator.services.mozilla.com/D157055

Bug 1790394 - Update pdf.js to new version 493bb65005202678c5fa803859dcf70cbb6e37a6 r=pdfjs-reviewers,marco

Differential Revision: https://phabricator.services.mozilla.com/D157118

This patch fixes the path issues with PerfDocs on Windows machines. To do this, all `os` path manipulations were converted to use `pathlib`. The encoding, and permissions of the files are also set properly now since Windows has different defaults. The tests were also fixed to be able to run on Windows machines.

Differential Revision: https://phabricator.services.mozilla.com/D156983

On the Pixel 6 family devices we are seeing frequent image corruption
issues on some websites, which started following the Android 13
upgrade. This can be avoided by not invalidating the no-longer-needed
render targets at the end of each render pass. This is only an
optimization anyway, so is safe to skip.

The Android 13 update upgraded the Mali driver from version v1.r32p1
to v1.r36p0. As we did not encounter this bug prior to the Android 13
update, this patch only applies the workaround on driver versions
v1.r36p0 and above. It's possible other GPUs than the G78 are also
affected, but for now we limit the workaround to just this GPU. We can
re-evaluate if and when we receive bug reports from users on other
GPUs.

Differential Revision: https://phabricator.services.mozilla.com/D157116

Differential Revision: https://phabricator.services.mozilla.com/D157123

Previously we were reusing the framebuffer's Skia DT to render the clip mask.
This was the path of least resistance since SkCanvas does not allow exporting
clip information, and there is no way to reset the bitmap storage inside an
SkCanvas temporarily.

However, this can cause a feedback cycle of unnecessary WaitForShmem operations,
since we need to wait before we can generate the clip mask into the Skia target,
and then anything else after it needs to wait for the clip mask to finish uploading
before the Skia DT can be used again.

To alleviate this, we just allocate a new DrawTargetSkia to render the clip mask
into. We carefully clip the size of the DT so that in the common case we avoid
having to upload a surface the size of the entire framebuffer. Further, since
this is a completely different DT, we can now use an A8 format (1/4 the memory
overhead) instead of a BGRA8 format for the clip mask, which gives a further
memory usage gain.

A further complication is that we need to log the current clip stack state so
that we can replay it onto the new DrawTargetSkia. This avoids having to add
a mechanism to SkCanvas to export clip information.

Differential Revision: https://phabricator.services.mozilla.com/D157050

Certain events like waiting on a round-trip to verify that the HostWebGLContext is
done using a shmem, or pushing a Skia layer which will need to be flatten later, can
be expensive, especially if they are used many times throughout a frame. However,
we weren't currently incremening the profile counters for these situations which can
lead to accelerated rendering persisting even when it would be more judicious to
fallback to software rendering.

Differential Revision: https://phabricator.services.mozilla.com/D157049

Sometimes the clip state is thrashed when we need to temporarily override
clipping to disable it. However, in this case, the clip mask itself remains
unchanged. The current invalidation scheme doesn't discern between generation
of the clip mask itself and setting the clip state for the shader, leading to
unnecessary regeneration of the clip mask.

This code just tries to discern when this is happening so we can refresh the
clip state without having to regenerate the clip mask unless truly necessary.

Differential Revision: https://phabricator.services.mozilla.com/D157048

Depends on D154482

Differential Revision: https://phabricator.services.mozilla.com/D146986

Bug 1775903 - update disabling condition to include all macosx1015 r=credential-management-reviewers,sgalich DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D157119

On the Pixel 6 family devices we are seeing frequent image corruption
issues on some websites, which started following the Android 13
upgrade. This can be avoided by not invalidating the no-longer-needed
render targets at the end of each render pass. This is only an
optimization anyway, so is safe to skip.

The Android 13 update upgraded the Mali driver from version v1.r32p1
to v1.r36p0. As we did not encounter this bug prior to the Android 13
update, this patch only applies the workaround on driver versions
v1.r36p0 and above. It's possible other GPUs than the G78 are also
affected, but for now we limit the workaround to just this GPU. We can
re-evaluate if and when we receive bug reports from users on other
GPUs.

Differential Revision: https://phabricator.services.mozilla.com/D157116

Backed out 2 changesets (bug 1785103) for causing failures at test_group_scrollend.html. CLOSED TREE

Backed out changeset 0b1a9ad58327 (bug 1785103)
Backed out changeset 2712b51e6b75 (bug 1785103)

Differential Revision: https://phabricator.services.mozilla.com/D157096

Matches other browsers and makes sense that width="100%" would behave
the same as width: 100% via CSS, I guess.

Differential Revision: https://phabricator.services.mozilla.com/D157021

The scrollend event should only be fired once, at the very end of the gesture.
Fire the event for user gestures only on APZStateChange::eTransformEnd, which
is dispatched when APZ transitions from a transforming state to a state that
does not transform (e.g. a state change from PANNING to NOTHING).
CompleteAsyncScroll() should only post the scrollend event if the scroll was a
programmatic instant scroll.

Differential Revision: https://phabricator.services.mozilla.com/D154834

Differential Revision: https://phabricator.services.mozilla.com/D155590

Most of the display: block stuff isn't needed anymore because we changed
the blockification behavior in bug 1789123.

.tab-stack, and stacks in general now uses CSS grid so doesn't need that
anymore.

DevTools is the only consumer of <xul:iframe> and width/height was
getting ignored in XUL because flexibility takes precedence, so just
remove the relevant declarations.

Differential Revision: https://phabricator.services.mozilla.com/D157070