Skip to content
Snippets Groups Projects
  1. Oct 25, 2017
    • Andreas Tolfsen's avatar
      Bug 1411281 - Add equality test for webdriver.Element r=jgraham · ffe20afd
      Andreas Tolfsen authored
      When comparing two instances of webdriver.Element we want to first
      check the type, to make sure the "id" attribute is present, then
      compare the web element reference UUIDs.  These are supposed to be
      unique across all browsing contexts.
      
      MozReview-Commit-ID: 68PUBQxPdQ5
      
      --HG--
      extra : rebase_source : f0c52efd0db3a13ea1b90dc6c058ebee2de76e1d
      ffe20afd
  2. Oct 26, 2017
    • Andreas Tolfsen's avatar
      Bug 1411281 - Add equality test for webdriver.Session r=jgraham · b0cfd277
      Andreas Tolfsen authored
      When comparing two instances of webdriver.Session we want to first
      check that there is a current session, then the type of the object
      to compare with to make sure the "session_id" attribute is present,
      then finally we compare the session IDs.
      
      MozReview-Commit-ID: 6Ch4Uy2MEhB
      
      --HG--
      extra : rebase_source : 252fe31680c57831b122d2bb53fe133b32c322eb
      b0cfd277
  3. Oct 25, 2017
  4. Oct 28, 2017
  5. Oct 26, 2017
  6. Oct 27, 2017
    • Daniel Holbert's avatar
      Bug 1412427 part 8: (automated patch) Switch a bunch of C++ files in gfx to... · 126bd9e1
      Daniel Holbert authored
      Bug 1412427 part 8: (automated patch) Switch a bunch of C++ files in gfx to use our standard mode lines. r=jrmuizel
      
      This patch was generated automatically by the "modeline.py" script, available
      here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
      
      For every file that is modified in this patch, the changes are as follows:
       (1) The patch changes the file to use the exact C++ mode lines from the
           Mozilla coding style guide, available here:
      https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
      
       (2) The patch deletes any blank lines between the mode line & the MPL
           boilerplate comment.
      
       (3) If the file previously had the mode lines and MPL boilerplate in a
           single contiguous C++ comment, then the patch splits them into
           separate C++ comments, to match the boilerplate in the coding style.
      
      MozReview-Commit-ID: 77D61xpSmIl
      
      --HG--
      extra : rebase_source : c6162fa3cf539a07177a19838324bf368faa162b
      126bd9e1
    • Daniel Holbert's avatar
      Bug 1412427 part 7: Manually fix up a few non-standard quirks in mode lines &... · de4b2b1c
      Daniel Holbert authored
      Bug 1412427 part 7: Manually fix up a few non-standard quirks in mode lines & MPL text, in gfx source files. r=jrmuizel
      
      MozReview-Commit-ID: JgK3UhG20kn
      
      --HG--
      extra : rebase_source : 2677c73948463f84eeafc4895697dbdcd5fccae4
      de4b2b1c
    • Daniel Holbert's avatar
      Bug 1412427 part 6: Remove stray "//" prefix before first line of MPL... · 3b352c72
      Daniel Holbert authored
      Bug 1412427 part 6: Remove stray "//" prefix before first line of MPL boilerplate comment, in some gfx source files. r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "//  \* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ####
      old="//  \* This Source Code Form is subject to the terms of the Mozilla Public"
      new=" \* This Source Code Form is subject to the terms of the Mozilla Public"
      sed -i s%"^$old"%"$new"% $1
      ####
      
      MozReview-Commit-ID: Ihx0EAOkT2g
      
      --HG--
      extra : rebase_source : 4dc97f234495e3ec1f4904e91d43d00fd3810626
      3b352c72
    • Daniel Holbert's avatar
      Bug 1412427 part 5: Deindent over-indented MPL boilerplate comments down to 1... · fc539779
      Daniel Holbert authored
      Bug 1412427 part 5: Deindent over-indented MPL boilerplate comments down to 1 space, for consistency & alignment. (whitespace-only) r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "  \* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      line1=" \* This Source Code Form is subject to the terms of the Mozilla Public"
      line2=" \* License, v\. 2\.0\. If a copy of the MPL was not distributed with this"
      line3=" \* file, You can obtain one at http://mozilla\.org/MPL/2\.0/\. \*/"
      
      # Strip off 1 space at beginning:
      sed -i s%"^ $line1"%"$line1"% $1
      sed -i s%"^ $line2"%"$line2"% $1
      sed -i s%"^ $line3"%"$line3"% $1
      ###
      
      MozReview-Commit-ID: EwCjyajgY4W
      
      --HG--
      extra : rebase_source : c61ca17ba556290d1f27af0a0c84e2ccc5371a36
      fc539779
    • Daniel Holbert's avatar
      Bug 1412427 part 4: Indent under-indented MPL boilerplate comments by 1 space,... · ecf5ee68
      Daniel Holbert authored
      Bug 1412427 part 4: Indent under-indented MPL boilerplate comments by 1 space, for consistency & alignment. (whitespace-only) r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "^\* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      line1="\* This Source Code Form is subject to the terms of the Mozilla Public"
      line2="\* License, v\. 2\.0\. If a copy of the MPL was not distributed with this"
      line3="\* file, You can obtain one at http://mozilla\.org/MPL/2\.0/\. \*/"
      
      # Insert 1 space at beginning:
      sed -i s%"^$line1"%" $line1"% $1
      sed -i s%"^$line2"%" $line2"% $1
      sed -i s%"^$line3"%" $line3"% $1
      ###
      
      MozReview-Commit-ID: HXBMrfnhlVr
      
      --HG--
      extra : rebase_source : de4c78563711f8366e2978c5199a5041875fbe38
      ecf5ee68
    • Daniel Holbert's avatar
      Bug 1412427 part 3: Replace 10 gfx usages of a particular non-standard emacs... · 76d8e6a7
      Daniel Holbert authored
      Bug 1412427 part 3: Replace 10 gfx usages of a particular non-standard emacs mode line with our standard mode line. r=jrmuizel
      
      This patch was mostly[1] automatically generated. I found the files to be fixed
      in this patch with the following command:
      grep -r "C++; indent-tabs-mode:" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      old="/\* -\*- Mode: C++; indent-tabs-mode: nil; c-basic-offset: 4 -\*- \*/"
      new="/\* -\*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -\*- \*/"
      
      sed -i s%"^$old"%"$new"% $1
      ###
      
      [1] NOTE: Nearly all of these files use 2-space indentation, so it's correct
      (from a consistency perspective and a reflecting-reality perspective) that
      we're reducing their "c-basic-offset: 4" down to "c-basic-offset: 2" here.  The
      one exception is nsDeviceContext.h, which *does* actually use 4-space
      indentation right now -- so I'm leaving that file with "c-basic-offset: 4" in
      its mode line.  This manual change (reverting 1 character from the automated
      process) is the only piece of this patch that isn't automated.
      
      MozReview-Commit-ID: L4MbyeYSbfY
      
      --HG--
      extra : rebase_source : 8ddbe422471bfd8b0060e96fb1c8cd062f10f290
      76d8e6a7
    • Daniel Holbert's avatar
      Bug 1412427 part 2: Move vim mode line below emacs mode line in a few gfx... · 0aa7ac89
      Daniel Holbert authored
      Bug 1412427 part 2: Move vim mode line below emacs mode line in a few gfx files, for consistency. r=jrmuizel
      
      This patch doesn't modify the mode lines at all -- it just swaps their order,
      and makes each one its own C++ comment, separate from the MPL boilerplate
      comment.
      
      MozReview-Commit-ID: BEZJVj2sMuK
      
      --HG--
      extra : rebase_source : 9e0946c8a8d0b67c11b5932b9d1e51e0e6e8ebef
      0aa7ac89
    • Daniel Holbert's avatar
      Bug 1412427 part 1: Add standard mode line & MPL boilerplate to a few gfx C++... · 976e9f7e
      Daniel Holbert authored
      Bug 1412427 part 1: Add standard mode line & MPL boilerplate to a few gfx C++ files that are missing it entirely. r=jrmuizel
      
      I copied the boilerplate comment directly from the Coding Style MDN page:
      https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
      
      MozReview-Commit-ID: 8rO6SfBIaRl
      
      --HG--
      extra : rebase_source : 90093621cbaa2a62b19e22b0eacad600fc586560
      976e9f7e
  7. Oct 30, 2017
  8. Oct 27, 2017
  9. Oct 26, 2017
  10. Oct 30, 2017
  11. Oct 29, 2017
  12. Oct 30, 2017
  13. Oct 27, 2017
  14. Oct 26, 2017
    • Nicholas Nethercote's avatar
      Bug 1410794 (attempt 2) - Change some |string| occurrences in... · 92524355
      Nicholas Nethercote authored
      Bug 1410794 (attempt 2) - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm.
      
      This makes the code nicer. In particular, it removes many getter_Copies()
      calls. The patch also converts a lot of nsCStrings to nsAutoCString, which will
      avoid heap allocation in the common case.
      
      The patch also renames PREF_CopyCharPref() as PREF_GetCStringPref(), because
      it's actually getting a string, not a char, and that matches the existing
      GetCString() and GetDefaultCString() methods. Correspondingly, it also renames
      PREF_SetCharPref() as PREF_SetCStringPref().
      
      The |aPrefName| arguments in nsIPrefBranch.idl remain as |string| because they
      almost always involve passing in C string literals, and passing "foo" is much
      nicer than passing NS_LITERAL_CSTRING("foo").
      
      It's worth noting that early versions of this patch used |AUTF8String| instead
      of |ACString|. But it turns out that libpref stores prefs internally as Latin1.
      And |ACString| is compatible with Latin1 but |AUTF8String| isn't, because
      non-ASCII Latin1 strings are not valid UTF-8!
      
      MozReview-Commit-ID: D3f7a1Vl1oE
      
      --HG--
      extra : rebase_source : e6e4b15d6d210cfd93686f96400281f02bd1d06b
      92524355
  15. Oct 30, 2017
Loading