bug_290: Add default bookmarks in alpha channel for testing

Merge Info

Related Issues

• #290 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports
• Merge to base-browser -!fixups to base-browser-specific commits, new features to be shared with tor-browser
  • NOTE: if your changeset includes patches to both base-browser and mullvad-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

How Tested

remove your profile with rm -r obj-x86_64-pc-linux-gnu/tmp/profile-default then run. the added bookmarks should be populated in the bookmark folder. alternatly hit ctrl-shift-b to see the bookmark toolbar, now with a QA folder

assigned to @dan

requested review from @henry

marked the checklist item ****No Backport (preferred): patchset for the next major stable as completed

marked the checklist item Merge to mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports as completed

marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

marked the checklist item Request review from an applications developer depending on modified system: as completed

Today I learnt about another legacy format: NETSCAPE-Bookmark-file-1. haha.

I'm pretty sure it is not specified, and the current parser doesn't interpret <dt> or <p>.

But for consistency, we should probably stick to whatever firefox does.

Alternatively, you could go with the older format (still used in tor browser) and never close any of the <dt> elements.

resolved all threads

added 1 commit

• 7bc726aa - fixup! MB 1: Mullvad Browser branding

Compare with previous version

marked this merge request as draft from dan/mullvad-browser@7bc726aa

added 1 commit

• 78a5fe53 - fixup! MB 1: Mullvad Browser branding

Compare with previous version