MB 383: Rebase MB alpha onto 128.5.0esr

Merge Info

Issues

Resolves

• #383 (closed)
• tor-browser#xxxxx
• tor-browser-build#xxxxx

Related

• mullvad-browser#xxxxx
• tor-browser#xxxxx
• tor-browser-build#xxxxx

Merging

Target Branches

• mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports
• base-browser and tor-browser - !fixups to base-browser-specific commits or new features to be shared with tor-browser
  • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and tor-browser branches here

Target Channels

• Alpha: esr128-14.5
• Stable: esr128-14.0

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

Usual rebase.

The template commit fixups had some conflicts I think weren't worth solving, as they don't contain code. So, I updated their target commit directly.

How Tested

• Range-diff against a squashed but unshuffled branch, looks okayish
• Diff of diffs has some noise because I must have forgotten to cherry-pick an uplift. Also, I changed some formatting of some comments while fixing commits in BB due to such uplift
• git diff mullvad-upstream/mullvad-browser-128.4.0esr-14.0-1 HEAD .gitlab/issue_templates looks okayish (the addition is due to aaaa0a99)