Skip to content

MB 387: Backport Bug 1910593 - Don't prefetch HTTPS RR if proxyDNS is enabled, r=necko-reviewers,valentin

Pier Angelo Vendrame requested to merge pierov/mullvad-browser:387-mb-backport-1910593 into mullvad-browser-128.5.0esr-14.5-1

Merge Info

Issues

Resolves

  • #387
  • tor-browser#xxxxx
  • tor-browser-build#xxxxx

Related

Merging

Target Branches

  • mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports
  • base-browser and tor-browser - !fixups to base-browser-specific commits or new features to be shared with tor-browser
    • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and tor-browser branches here

Target Channels

  • Alpha: esr128-14.5
  • Stable: esr128-14.0

Backporting

Timeline

  • No Backport (preferred): patchset for the next major stable
  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, morgan
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, morgan
    • security : jwilde, ma1
    • signing : boklm, morgan
    • updater : pierov
    • windows : jwilde, morgan
    • misc/other : pierov, morgan

Change Description

Backported Bug 1910593 (ead6562a) as requested by Rui.

There was a conflict because of an upstream patch that was backported to ESR.

Being an upstream backport, we might want it in Tor Browser as well, but since proxies are involved (possibly proxy obedience, though), we should have a more careful look at it before backporting.

How Tested

Not sure how to test it.

@ruihildt if I get you a testbuild, can you check if the problems are solved?

Related to #387

Merge request reports