Skip to content

Include a manifest for mullvadbrowser.exe

Merge Info

Related Issues

Backport Timeline

  • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
  • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
  • Eventually - patchset that needs to be verified in alpha before backport
  • No Backport - patchset for the next major stable

Issue Tracking

Change Description

This patch renames (and updates) the firefox.exe.manifest (which gets embedded in the final browser executable binary) to mullvadbrowser.exe.manifest. The underlying issue is that windows ran mullvadbrowser.exe which contained no manifest. Since I had a high DPI display, Windows helpfully doubled the underlying reported DPI to the browser so that it would render properly (assuming that it was dealing with a very legacy win32 application from before the time of application manifests). Firefox also takes care of scaling based on system DPI, so seeing the system was 2x scaling, it also doubles the scrollbar width resulting in a much too large scrollbar.

We should possible file an upstream ticket with Mozilla about this silent failure mode when the application exe is renamed.

Edited by Pier Angelo Vendrame

Merge request reports