MB 70 (undo): Show the notification about the available languages
requested to merge pierov/mullvad-browser:198-mb-enable-loc-bar into mullvad-browser-115.1.0esr-13.0-1
Merge Info
Related Issues
Backporting
Timeline
-
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport -
No Backport (preferred): patchset for the next major stable
(Optional) Justification
-
Emergency security update: patchset fixes CVEs, 0-days, etc -
Critical bug-fix: patchset fixes a bug in core-functionality -
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc -
Sponsor required: patchset required for sponsor -
Other: please explain
Merging
-
Merge to mullvad-browser
-!fixups
tomullvad-browser
-specific commits, new features, security backports -
Merge to base-browser
-!fixups
tobase-browser
-specific commits, new features to be shared withtor-browser
-
NOTE: if your changeset includes patches to both
base-browser
andmullvad-browser
please clearly label in the change description which commits should be cherry-picked tobase-browser
after merging
-
NOTE: if your changeset includes patches to both
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
-
Request review from an applications developer depending on modified system: -
NOTE: if the MR modifies multiple areas, please
/cc
all the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
- android : dan
- build system : boklm
- extensions : ma1
- firefox internals (XUL/JS/XPCOM) : ma1
- fonts : pierov
- frontend (implementation) : henry
- frontend (review) : donuts, richard
- localization : henry, pierov
- nightly builds : boklm
- rebases/release-prep : dan_b, ma1, pierov, richard
- security : ma1
- signing : boklm, richard
- updater : pierov
- misc/other : pierov, richard
-
NOTE: if the MR modifies multiple areas, please
Change Description
Mullvad Browser #198 (closed) is about adding the various translations to Mullvad Browser.
However, we should also advertise them with the language notification bar.
In #70 (closed) I used a hack: I set the preference about having shown them to true
, to avoid having the notification and then show only English as available.
In tor-browser-build!775 (merged) we're enabling the languages and injecting the Mullvad Fluent files, but we should also tell users that now localization is available by showing them the bar.
If everything goes as planned, updating users will switch from their old default (true
) to the new default (false
), and they'll also be presented the notification.
However, I didn't test it.