change
if (nsnull == menu) {
to
if (NS_OK == rv) {
which makes submenus be added correctly.