Skip to content

MB 141: Update generated mar's mar channel id string to mullvadbrowser-mullvad-

morgan requested to merge morgan/tor-browser-build-s131:bug_141 into main

Merge Info

Related Issues

  • privacy-browser#141

Backport Timeline

  • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
  • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
  • Eventually - patchset that needs to be verified in alpha before backport
  • No Backport - patchset for the next major stable

Issue Tracking

Change Description

So our generated mars have the wrong channel id specified, because we have been (justifiably) been hardcoding the torbrowser-torproject- portion everywhere we generate MARs. This patch creates a new var/mar_channel_id parameter and sets it appropriately. Where possible we pass in the param directly to the various scripts, though for the update_responses script we set the MAR_CHANNEL_ID environment variable before invoking.

I'll do a test 12.0a10 build to verify I haven't broken anything on the build side, but will need to also verify the signing portion after.

Merge request reports