Bring Noto Sans Gurmukhi and Sinhala back

We removed these fonts because we initially thought they were the cause of #40387 (closed).

However, with tor-browser#40685 (closed) solved, we should be able to bring them back.

assigned to @pierov

changed milestone to %Tor Browser: 11.0 Issues with previous release

added Doing label

obligatory link: #40387 (comment 2763832) :)

Already asked: https://bugzilla.mozilla.org/show_bug.cgi?id=1745715

Oh I know that - I live on bugzilla I just wanted to highlight myself, I'm feeling lonely

I was just pointing out that the previous fix obviously wasn't a fix. I have done a fair bit of reading/testing re RFP font protections (and making sure they worked with RFP on at least windows) and been part of three or four fixes already. I should have clicked way earlier that it was the bundled fonts, but I know nothing about how TB Linux compiles the font whitelist or whatever. I am surprised the bundled ones were ever detected as system ones - legacy issues perhaps. I hope you reverse that to not diverge from upstream

Thanks for the upcoming patches

Yeah, we are waiting to hear back, and then we will apply the same patch.

<dir>fonts</dir> can also be removed, the fingerprint seems not to change but I forgot to ask about it at the Browser meeting...

mentioned in merge request !386 (merged)

closed with merge request !386 (merged)

mentioned in commit bb28297a

@pierov don't forget the <dir>fonts</dir> issue

Thanks for the reminder, I forgot again to ask last Monday.

Actually, keeping it is okay for me. It does not hurt, and it can be a fallback in case the bundled fonts mechanism has some bugs... (Although this can be a disadvantage, because we should notice bugs, instead of keeping them quiet).

@boklm did you add the fonts.conf file originally? In case, do you remember if there is a reason behind the <dir>fonts</dir>?

Thanks!

I think bundled fonts should be detected as bundled - who knows what jonathan kew's patches could spring in future and whitelist is not "supported" - and I couldn't have tested whitelist on Linux UNTIL you built alpha ESR91, unlike I did test windows well before time (and got someone else to test mac). Interested in boklm's thoughts/answer

mentioned in issue tor-browser#40737 (closed)

FWIW: that made it into 11.0.4 with commit bb28297a.