Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T tor-browser-build
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 209
    • Issues 209
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • tor-browser-build
  • Issues
  • #40699
Closed
Open
Issue created Nov 29, 2022 by boklm@boklmMaintainer

Fix input_files in projects/firefox-l10n/config

In input_files in projects/firefox-l10n/config we are doing this:

      my $locales = project_config($project, 'var/locales', $options);
      foreach my $locale (@$locales) {
        $locale = process_template($project, $locale, '.');

In this foreach loop, $locale is pointing to the real string from var/locales and not a copy, and we are updating it with the output from process_template. This means that the template will be processed the first time the function is called (for example for a linux-x86_64 build) and the processed value from the first call reused on subsequent calls (for example a macos build, where the ja locale is supposed to be different).

This is what caused the reproducibility issue in !591 (comment 2857042)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking