Review and standardize naming scheme for browser installer/package artifacts

added Roadmap::Future label

added Sponsor 131 label

added All Platforms Build System labels

added Feature label

marked this issue as related to #40901 (closed)

marked this issue as related to mullvad-browser#180 (closed)

marked this issue as related to #27457 (closed)

assigned to @boklm

added Doing label

I think nameing scheme could be something like this:

(tor|mullvad)-browser-(linux-x86_64|linux-i686|windows-x86_64|windows-i686|macos|android-armv7|android-x86|android-x86_64|android-aarch64)-$version.(tar.xz|zip|exe|dmg|apk)

I started a patch for this naming scheme: boklm/tor-browser-build@145e8007

And started nightly builds for mullvadbrowser and torbrowser.

We might add a portable and installer on Windows, as suggested on mullvad-browser#180 (closed).

Apart form that, this scheme works for me.

And started nightly builds for mullvadbrowser and torbrowser.

The result of this build was:

mullvadbrowser/nightly/tbb-nightly.2023.08.02/:
build-infos-linux-x86_64.json    mar-tools-windows-x86_64.zip                                 mullvad-browser-systeminstall-windows-x86_64-tbb-nightly.2023.08.02.exe
build-infos-macos.json           mullvad-browser-linux-x86_64-debug.tar.xz                    mullvad-browser-windows-x86_64-debug.zip
build-infos-windows-x86_64.json  mullvad-browser-linux-x86_64-tbb-nightly.2023.08.02.tar.xz   mullvad-browser-windows-x86_64-tbb-nightly.2023.08.02.exe
geckodriver-linux-x86_64.tar.xz  mullvad-browser-linux-x86_64-tbb-nightly.2023.08.02_ALL.mar  mullvad-browser-windows-x86_64-tbb-nightly.2023.08.02_ALL.mar
mar-tools-linux-x86_64.zip       mullvad-browser-macos-tbb-nightly.2023.08.02_ALL.mar         sha256sums-unsigned-build.txt
mar-tools-macos-x86_64.zip       mullvad-browser-macostbb-nightly.2023.08.02.dmg              src-firefox-007f5b3e4faa.tar.xz

torbrowser/nightly/tbb-nightly.2023.08.02/:
build-infos-linux-i686.json      sha256sums-unsigned-build.txt                            tor-browser-windows-i686-tbb-nightly.2023.08.02.exe
build-infos-linux-x86_64.json    src-firefox-93ef5b2d79c9.tar.xz                          tor-browser-windows-i686-tbb-nightly.2023.08.02_ALL.mar
build-infos-macos.json           tor-browser-linux-i686-debug.tar.xz                      tor-browser-windows-x86_64-debug.zip
build-infos-windows-i686.json    tor-browser-linux-i686-tbb-nightly.2023.08.02.tar.xz     tor-browser-windows-x86_64-tbb-nightly.2023.08.02.exe
build-infos-windows-x86_64.json  tor-browser-linux-i686-tbb-nightly.2023.08.02_ALL.mar    tor-browser-windows-x86_64-tbb-nightly.2023.08.02_ALL.mar
geckodriver-linux-x86_64.tar.xz  tor-browser-linux-x86_64-debug.tar.xz                    tor-expert-bundle-tbb-nightly.2023.08.02-linux-i686.tar.gz
mar-tools-linux-i686.zip         tor-browser-linux-x86_64-tbb-nightly.2023.08.02.tar.xz   tor-expert-bundle-tbb-nightly.2023.08.02-linux-x86_64.tar.gz
mar-tools-linux-x86_64.zip       tor-browser-linux-x86_64-tbb-nightly.2023.08.02_ALL.mar  tor-expert-bundle-tbb-nightly.2023.08.02-macos-aarch64.tar.gz
mar-tools-macos-x86_64.zip       tor-browser-macos-tbb-nightly.2023.08.02_ALL.mar         tor-expert-bundle-tbb-nightly.2023.08.02-macos-x86_64.tar.gz
mar-tools-windows-i686.zip       tor-browser-macostbb-nightly.2023.08.02.dmg              tor-expert-bundle-tbb-nightly.2023.08.02-windows-i686.tar.gz
mar-tools-windows-x86_64.zip     tor-browser-windows-i686-debug.zip                       tor-expert-bundle-tbb-nightly.2023.08.02-windows-x86_64.tar.gz

I changed the following:

rebased on !762 (merged) to do android builds too
fixed dmg filename (missing - before version)
added the word portable and install (between tor-browser/mullvad-browser and platform) for windows bundles
added version number to mar-tools
moved platform before version for tor-expert-bundle
added version to geckodriver filename
updated debug files to follow the naming scheme (and renamed them as debug-symbols)

boklm/tor-browser-build@fe816970

And restarted a nightly build.

The result of latest build was:

$ ls torbrowser/nightly/tbb-nightly.2023.08.07/
build-infos-linux-i686.json                                           tor-browser-portable-windows-i686-tbb-nightly.2023.08.07.exe
build-infos-linux-x86_64.json                                         tor-browser-portable-windows-x86_64-tbb-nightly.2023.08.07.exe
build-infos-macos.json                                                tor-browser-tbb-nightly.2023.08.07-android-aarch64-multi-qa.apk
build-infos-windows-i686.json                                         tor-browser-tbb-nightly.2023.08.07-android-aarch64-multi-qa.apk.idsig
build-infos-windows-x86_64.json                                       tor-browser-tbb-nightly.2023.08.07-android-armv7-multi-qa.apk
geckodriver-linux-x86_64-tbb-nightly.2023.08.07.tar.xz                tor-browser-tbb-nightly.2023.08.07-android-armv7-multi-qa.apk.idsig
mar-tools-linux-i686-tbb-nightly.2023.08.07.zip                       tor-browser-tbb-nightly.2023.08.07-android-x86-multi-qa.apk
mar-tools-linux-x86_64-tbb-nightly.2023.08.07.zip                     tor-browser-tbb-nightly.2023.08.07-android-x86-multi-qa.apk.idsig
mar-tools-macos-x86_64-tbb-nightly.2023.08.07.zip                     tor-browser-tbb-nightly.2023.08.07-android-x86_64-multi-qa.apk
mar-tools-windows-i686-tbb-nightly.2023.08.07.zip                     tor-browser-tbb-nightly.2023.08.07-android-x86_64-multi-qa.apk.idsig
mar-tools-windows-x86_64-tbb-nightly.2023.08.07.zip                   tor-browser-windows-i686-tbb-nightly.2023.08.07_ALL.mar
sha256sums-unsigned-build.txt                                         tor-browser-windows-x86_64-tbb-nightly.2023.08.07_ALL.mar
src-firefox-93ef5b2d79c9.tar.xz                                       tor-expert-bundle-android-aarch64-tbb-nightly.2023.08.07.tar.gz
tor-browser-debug-symbols-linux-i686-tbb-nightly.2023.08.07.tar.xz    tor-expert-bundle-android-armv7-tbb-nightly.2023.08.07.tar.gz
tor-browser-debug-symbols-linux-x86_64-tbb-nightly.2023.08.07.tar.xz  tor-expert-bundle-android-x86-tbb-nightly.2023.08.07.tar.gz
tor-browser-debug-symbols-windows-i686-tbb-nightly.2023.08.07.zip     tor-expert-bundle-android-x86_64-tbb-nightly.2023.08.07.tar.gz
tor-browser-debug-symbols-windows-x86_64-tbb-nightly.2023.08.07.zip   tor-expert-bundle-linux-i686-tbb-nightly.2023.08.07.tar.gz
tor-browser-linux-i686-tbb-nightly.2023.08.07.tar.xz                  tor-expert-bundle-linux-x86_64-tbb-nightly.2023.08.07.tar.gz
tor-browser-linux-i686-tbb-nightly.2023.08.07_ALL.mar                 tor-expert-bundle-macos-aarch64-tbb-nightly.2023.08.07.tar.gz
tor-browser-linux-x86_64-tbb-nightly.2023.08.07.tar.xz                tor-expert-bundle-macos-x86_64-tbb-nightly.2023.08.07.tar.gz
tor-browser-linux-x86_64-tbb-nightly.2023.08.07_ALL.mar               tor-expert-bundle-windows-i686-tbb-nightly.2023.08.07.tar.gz
tor-browser-macos-tbb-nightly.2023.08.07.dmg                          tor-expert-bundle-windows-x86_64-tbb-nightly.2023.08.07.tar.gz
tor-browser-macos-tbb-nightly.2023.08.07_ALL.mar
$ ls mullvadbrowser/nightly/tbb-nightly.2023.08.0
tbb-nightly.2023.08.02/ tbb-nightly.2023.08.07/
boklm@tb-build-05:~/tor-browser-build$ ls mullvadbrowser/nightly/tbb-nightly.2023.08.07/
build-infos-linux-x86_64.json                                             mullvad-browser-install-windows-x86_64-tbb-nightly.2023.08.07.exe
build-infos-macos.json                                                    mullvad-browser-linux-x86_64-tbb-nightly.2023.08.07.tar.xz
build-infos-windows-x86_64.json                                           mullvad-browser-linux-x86_64-tbb-nightly.2023.08.07_ALL.mar
geckodriver-linux-x86_64-tbb-nightly.2023.08.07.tar.xz                    mullvad-browser-macos-tbb-nightly.2023.08.07.dmg
mar-tools-linux-x86_64-tbb-nightly.2023.08.07.zip                         mullvad-browser-macos-tbb-nightly.2023.08.07_ALL.mar
mar-tools-macos-x86_64-tbb-nightly.2023.08.07.zip                         mullvad-browser-portable-windows-x86_64-tbb-nightly.2023.08.07.exe
mar-tools-windows-x86_64-tbb-nightly.2023.08.07.zip                       mullvad-browser-windows-x86_64-tbb-nightly.2023.08.07_ALL.mar
mullvad-browser-debug-symbols-linux-x86_64-tbb-nightly.2023.08.07.tar.xz  sha256sums-unsigned-build.txt
mullvad-browser-debug-symbols-windows-x86_64-tbb-nightly.2023.08.07.zip   src-firefox-007f5b3e4faa.tar.xz

It turns out android apks are not using the new naming scheme, but has version before platform (like was doing tor-expert-bundle).

So I will change android to use the new naming scheme.

Now that I see it, I wonder if windows-i686 and windows-x86_64 is clear enough for all Windows users.

I changed the android filenames in boklm/tor-browser-build@be795a9a

While changing the android filenames, I'm thinking about renaming multi-qa to just qa (as I'm not sure what the multi means), and moving the qa at the begining after the browser name instead of the end.

So the unsigned apk would be something like:

tor-browser-qa-android-aarch64-tbb-nightly.2023.08.07.apk

and the signed one:

tor-browser-android-aarch64-tbb-nightly.2023.08.07.apk

Now that I see it, I wonder if windows-i686 and windows-x86_64 is clear enough for all Windows users.

Do you have ideas about something that could make it more clear? I think that should already be more clear than what we had before, which was install-win64 and install.

But most users will probably download from the web page on https://www.torproject.org/download/ which only has one Windows build, unless you click on Download for another platform.

Would win32 and win64 work?

I think they're uglier, but they seem less technical than i686.

@pierov so win64 isn't really a thing. I mean it kind of is but also includes things like itanium and aarch64. I think we should keep the filename as i686/x86_64 for accuracy+consistency with the rest and platforms and rely on the website download page to direct windows users to the right package.

win64 isn't really a thing.

I get that it isn't correct, but it's widely spread, and people are accustomed to it.

I think i686 is especially the one confusing for non-technical people. Usually users should go through download pages, but donuts suggested that users might not open a file if they don't recognize it or they think it's suspicious.

I like consistency, fwiw.

yes consistency please. I really doubt there are a significant number of users technically inclined enough to be suspicious of a filename to make them not run it (rather than yolo running whatever they download) who would also be confused about a cpu-architecture tag.

While changing the android filenames, I'm thinking about renaming multi-qa to just qa (as I'm not sure what the multi means), and moving the qa at the begining after the browser name instead of the end.

I did that change in boklm/tor-browser-build@b2264eb4

And started a nightly build with that commit.

Should we make the mar tools coherent with this? And therefore also the debug symbols, for which I stuck to the mar convention and eventually geckodriver.

Should we make the mar tools coherent with this? And therefore also the debug symbols, for which I stuck to the mar convention and eventually geckodriver.

Yes, it looks like a good idea, I will update the patch to do that.

Maybe debug can be changed to debug-symbols to make it more clear what it is?

Actually it contains both the debug symbols and the generated headers.

But debug-symbols should be okay.

Maybe we could rename also the intermediate archives we produce in projects/firefox to debug-symbols.

Maybe we could rename also the intermediate archives we produce in projects/firefox to debug-symbols.

Ok, I did that in boklm/tor-browser-build@564654ad

marked this issue as related to #40912

mentioned in issue #40912

mentioned in issue mullvad-browser#180 (closed)

mentioned in merge request !762 (merged)

removed the relation with #40901 (closed)

marked this issue as related to #40914 (closed)

marked this issue as related to #40915 (closed)

mentioned in merge request !778 (merged)

Review and standardize naming scheme for browser installer/package artifacts

Child items ...

Activity