Update licenses for PTs

Currently, we ship a license file in projects/browser/Bundle-Data/Docs-TBB/Licenses/PluggableTransports/LICENSE, but we haven't updated in it in a very long time (last time was 723c63a0).

We should probably update it, or even use the go-licenses tool to make sure we always generated an updated copy (I don't know if this tool needs to work online though).

marked this issue as related to #40611

mentioned in merge request !1183 (merged)

assigned to @pierov

So, I created a new container and I installed go.

I took far too long to understand that go shouldn't be installed in ~/go for stuff to work as expected, my bad.

Anyway, after extracting the tarball and renaming the go directory, I installed go-licenses:

go install github.com/google/go-licenses@latest

Then, I cloned lyrebird, went there, and ran go-licenses:

git clone https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyrebird.git
cd lyrebird
~/go/bin/go-licenses save --save_path ../licenses-lyrebird ./cmd/lyrebird

Same for conjure:

git clone  https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/conjure.git
cd conjure
~/go/bin/go-licenses save --save_path ../licenses-conjure ./client

For both, I got some warning about assembly files, but I guess they are covered in the same licensing terms of the package.

Some packages are used by both the PTs, and their license files are the same.

I didn't find any conflicting file, so I merged the directories:

mkdir licenses
cp -r licenses-lyrebird/* licenses-conjure/* licenses/

It's a lot of license files: it's 497 files, for 568K (du -hs licenses).

The easiest thing to do is to combine the files in a single txt.

Like

$file1name
==================================
$file1content

$file2name
==================================
$file2content

The invidivual licenses files

The merged licenses.txt

I think this could be easily added to tor-browser-build, either in the PT projects (if we manage to run it offline) or in the go_vendor step.

Oh, well.

Building with go 1.23 seems to fail, I get this:

# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_linux.go:2270:9: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

(and nothing saying this is an error ).

I wonder if it's an easy fix, or if there's a fork that updated to Go > 1.16.

mentioned in merge request !1188 (merged)

marked this issue as related to #41404

closed

added Build System label