Bug 41211: Replace Google's oss-license-plugin binaries with our patched build
Merge Info
Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- #41211 (closed)
Backporting
Timeline
-
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport -
No Backport (preferred): patchset for the next major stable
(Optional) Justification
-
Emergency security update: patchset fixes CVEs, 0-days, etc -
Censorship event: patchset enables censorship circumvention -
Critical bug-fix: patchset fixes a bug in core-functionality -
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc -
Sponsor required: patchset required for sponsor -
Other: please explain
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
-
Request review from an applications developer depending on modified system: -
NOTE: if the MR modifies multiple areas, please
/cc
all the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
- android : @clairehurst, @dan
- build system : @boklm
- extensions : ma1
- firefox internals (XUL/JS/XPCOM) : jwilde, ma1
- fonts : pierov
- frontend (implementation) : henry
- frontend (review) : donuts, morgan
- localization : henry, pierov
- macOS : clairehurst, dan
- nightly builds : boklm
- rebases/release-prep : boklm, dan, ma1, morgan, pierov
- security : jwilde, ma1
- signing : boklm, morgan
- updater : pierov
- windows : jwilde, morgan
- misc/other : @morgan, pierov
-
NOTE: if the MR modifies multiple areas, please
Change Description
In this MR, we create a new project: oss-license-plugin
.
We also include two patches:
- use a
TreeSet
rather than aHashSet
to make the output stable. To do so, I had to implementComparable
on the type used in the Set - do a couple of fixes to the build file:
- fix incompatibilities with the version of Gradle we use (8.8, currently), in particular the
maven
plugin has been renamed tomaven-publish
- use offline dependencies (the
mavenLocal()
name) - use a local publication, rather than the original one Google implemented (which was also incompatible with our Gradle version, or created some other problems I don't understand, so I deleted it)
- fix incompatibilities with the version of Gradle we use (8.8, currently), in particular the
How Tested
Built on tb-build-03 and locally, and got matching results.