Bug 41247: Add torbrowser_legacy_version to update-responses

Merge Info

Related Issues

• tor-browser#xxxxx
• mullvad-browser#xxxxx
• #41247 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : boklm, dan, ma1, morgan, pierov
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : morgan, pierov

Change Description

I made the changes in separate commits:

• Drop sha512 hash from update_responses files
• Simplify tools/update-responses/update_responses (remove support for calling the script without specifying the channel)
• Add support for multiple versions in update_responses
• Add torbrowser_legacy_version to update-responses

How Tested

• I checked that on the first commit (dropping sha512 hash) make torbrowser-update_responses-alpha generates updates responses without the sha512
• I checked that on the third commit (adding support for multiple versions in update_responses, but with projects/release/update_responses_config.yml unchanged), the generated updates responses as exactly the same than with the first commit
• I checked that on the last commit, the generated updates responses contain both 14.0a7 and 13.5a10 and look correct. The generated update-responses can be downloaded here: https://tb-build-02.torproject.org/~boklm/tmp/update-responses-alpha-14.0a7.tar
• I checked that make torbrowser-incrementals-alpha is still working

/cc @pierov