Skip to content

Bug 41286: Update the deploy update scripts to optinally take an override hash

boklm requested to merge boklm/tor-browser-build:bug_41286 into main

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, morgan
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, morgan, pierov
    • security : jwilde, ma1
    • signing : boklm, morgan
    • updater : pierov
    • windows : jwilde, morgan
    • misc/other : morgan, pierov

Change Description

How Tested

As it's not easy to test the script without publishing a release, I tested with thoses changes to the script: boklm/tor-browser-build@aa27f9de

$ SIGNING_PROJECTNAME=torbrowser ./upload-update_responses-to-staticiforme 
deploy_script: /tmp/tmp.LLHGwf3z0b
$ cat /tmp/tmp.LLHGwf3z0b
#!/bin/bash
set -e

if test "$#" -gt 1; then
  echo >&2 "Wrong number of arguments"
  exit 2
fi

commit=TEST1
test "$#" -eq 1 && commit="$1"

test "$#" -eq 0 && echo "Deploying version 13.5.7"
echo "update_responses_commit: $commit"

echo git checkout "$commit"

$ /tmp/tmp.LLHGwf3z0b
Deploying version 13.5.7
update_responses_commit: TEST1
git checkout TEST1
$ /tmp/tmp.LLHGwf3z0b A
update_responses_commit: A
git checkout A
$ /tmp/tmp.LLHGwf3z0b A b
Wrong number of arguments

Merge request reports