Bug 41328: Exclude tor dependencies from LD_LIBRARY_PATH.

Merge Info

Issues

Resolves

• #41328
• tor-browser#43326
• mullvad-browser#xxxxx

Related

• tor-browser-build#xxxxx
• tor-browser#xxxxx
• mullvad-browser#xxxxx

Merging

Target Branches

• main: esr128-14.5
• maint-14.0: esr128-14.0
• maint-13.5: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
  • The browser doesn't start on up to date Gentoo. Users have to manually delete our libcrypto. See also tor-browser!1301.
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : boklm, dan, ma1, morgan, pierov
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : morgan, pierov

Change Description

Removed TorBrowser/Tor from LD_LIBRARY_PATH as we are going to add it only when starting the tor daemon (see tor-browser!1301).

How Tested

Testbuild: https://tb-build-03.torproject.org/\~pierov/testbuild/tor-browser-linux-x86_64-testbuild-43326.tar.xz

Tor seems to work normally.

I was told from the reporter of the tor-browser issue it fixed the problem for them.