Bug 41374+40799: Remove support for migrate_archs and migrate_langs in update_responses + Remove legacy locale iteration in update-responses and dmg2mar
Merge Info
Issues
Resolves
- #41374 (closed)
- #40799 (closed)
- tor-browser#xxxxx
- mullvad-browser#xxxxx
Related
- tor-browser-build#xxxxx
- tor-browser#xxxxx
- mullvad-browser#xxxxx
Merging
Target Branches
-
main: esr128-14.5 -
maint-14.0: esr128-14.0 -
maint-13.5: esr115-13.5
Backporting
Timeline
-
No Backport (preferred): patchset for the next major stable -
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport
(Optional) Justification
-
Emergency security update: patchset fixes CVEs, 0-days, etc -
Censorship event: patchset enables censorship circumvention -
Critical bug-fix: patchset fixes a bug in core-functionality -
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc -
Sponsor required: patchset required for sponsor -
Other: please explain
We should backport this to maint-14.0 if/when we want #41363 (closed) in maint-14.0.
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
-
Request review from an applications developer depending on modified system: -
NOTE: if the MR modifies multiple areas, please
/ccall the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
- android : clairehurst, dan
- build system : boklm
- extensions : ma1
- firefox internals (XUL/JS/XPCOM) : jwilde, ma1
- fonts : pierov
- frontend (implementation) : henry
- frontend (review) : donuts, morgan
- localization : henry, pierov
- macOS : clairehurst, dan
- nightly builds : boklm
- rebases/release-prep : boklm, dan, ma1, morgan, pierov
- security : jwilde, ma1
- signing : boklm, morgan
- updater : pierov
- windows : jwilde, morgan
- misc/other : morgan, pierov
-
NOTE: if the MR modifies multiple areas, please
Change Description
- Remove support for migrate_archs and migrate_langs in update_responses
- Remove legacy locale iteration in update-responses
- Remove legacy locale support in tools/dmg2mar
How Tested
- Tested that
make torbrowser-dmg2mar-alphais still working - Tested that
make torbrowser-incrementals-alphais still working and produce the same mar files - Tested that
make torbrowser-update_responses-alphais still working. Checked that the only change in the output is the name of the.xmlfiles (and in the.htaccesspointing to them) which don't include the locale (ALL) anymore.
Edited by boklm