Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T tor-browser-build
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 215
    • Issues 215
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • tor-browser-build
  • Merge requests
  • !3

WIP: Bug 34432

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Georg Koppen requested to merge gk/tor-browser-build:bug_34432_v3 into master Jun 23, 2020
  • Overview 50
  • Commits 27
  • Changes 40

This request is about merging the fixes to the 16 child tickets mentioned in #34432 (closed). That should allow us to keep both the new toolchain and the older ones on tor-browser-builds master and make progress on building a Fenix-based Tor Browser.

To test the changes I pushed bug_34432_v3_test with an additional commit to pick up a rebased GeckoView branch. Using that branch running

./rbm/rbm build fenix-tor-android-service --target torbrowser-testbuild --target torbrowser-android-fenix-armv7 (replace "armv7" for the other architecture)

and

./rbm/rbm build geckoview --step merge_aars --target torbrowser-testbuild --target torbrowser-android-all

should build everything for that is getting changed for Fenix.

Compared to the previous review done by @ahf I needed make 4 smaller and larger changes (IIRC):

  1. Node has a newer version now (10.21)
  2. I found a bug in cbindgen I fixed
  3. I needed to adjust things for the fenix- namespace where required, so we can keep everything on master
  4. I needed to take upcoming changes for application-services into account as that project requires a newer NDK (r21).
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bug_34432_v3