Skip to content
Snippets Groups Projects

Bug 40323: Remove unused patch files

Closed Georg Koppen requested to merge gk/tor-browser-build:bug_40323_v2 into master
All threads resolved!

Closes #40323 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Georg Koppen requested review from @boklm

    requested review from @boklm

  • assigned to @gk

  • I think those .patch files are used. They are listed in input_files in the config files. There is no build file for those projects because they are using var/build_go_lib from projects/go/config, which includes:

        for p in $(ls -1 $rootdir/*.patch 2> /dev/null | sort)
        do
          patch -p1 < $p
        done

    Although, I noticed that apparently we are not using the gomobile project anywhere, so we can probably remove it.

    • Author Developer
      Resolved by Georg Koppen

      I think those .patch files are used. They are listed in input_files in the config files. There is no build file for those projects because they are using var/build_go_lib from projects/go/config, which includes:

          for p in $(ls -1 $rootdir/*.patch 2> /dev/null | sort)
          do
            patch -p1 < $p
          done

      That's a good catch, thanks!

      Although, I noticed that apparently we are not using the gomobile project anywhere, so we can probably remove it.

      I was confused about the gomobile project as we seem to still use it if the creation in eee5d30a was correct. But I guess that's an oversight from your previous work we missed? If so, I can use #40323 (closed) to remove the gomobile patch and the whole project while we are at it.

  • Georg Koppen resolved all threads

    resolved all threads

  • Author Developer

    Superseded by !311 (merged).

  • closed

  • Georg Koppen mentioned in merge request !311 (merged)

    mentioned in merge request !311 (merged)

Please register or sign in to reply
Loading