Skip to content

Bug 40732: Review the Bundle-Data and do not ship the default profile

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_40732 into main

Merge Info

Related Issues

Backport Timeline

  • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
  • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
  • Eventually - patchset that needs to be verified in alpha before backport
  • No Backport - patchset for the next major stable

Issue Tracking

Change Description

This commit reviews the entire Bundle-Data mechanism, and it does maybe too many things:

  1. we stop shipping Bundle-Data/$osname in base-browser, which results in not shipping a default profile anymore (except for Tor Browser);
  2. Linux's start script referred the default profile: we must not do it anymore, and since it isn't required on Linux either, I've just removed these lines also for Tor Browser;
  3. In tor-browser!517 (merged)/tor-browser!518 (merged), we've disabled the profile migrator at Firefox build config level: we do not need to ship the override.ini anymore (we did for macOS);
  4. macOS files in Bundle-Data did not follow the final structure, and we had to move them while building. If I understand correctly, it was legacy, so get rid of it;
  5. finally, the commit reworks the template for the .dmg files: instead of having two generic dmg, one to install to /Applications (which is the only one used) and one for ~/Desktop, we now have two templates: one for Tor Browser, and one for Base Browser.

The branch for this MR includes the commit for !627 (merged), which should be merged, first, to avoid conflicts with the DMG HFS+Icon changes.

Edited by richard

Merge request reports