Skip to content

Bug 40847: Do not rely on du to compute the HFS size

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_40847 into main

Merge Info

Related Issues

Backport Timeline

  • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
  • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
  • Eventually - patchset that needs to be verified in alpha before backport
  • No Backport - patchset for the next major stable

Issue Tracking

Change Description

When I built the browser project in ramdisk to be quicker, I found that the HFS filesystem had a different size, wrt the one richard got while building in ext4.

I usually use a btrfs, which ends up in the same size as ext4, so we never caught this before, but different configurations could lead to non reproducibility.

This MR should be merged after 12.5a5 is merged, imho, since then I've build in the usual FS and confirmed we get the same hash (the contents were already the same).

Merge request reports