Skip to content

Bug 41089: Register file types in the Mullvad Browser installer.

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_41089 into main

Merge Info

Related Issues



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

Changes to support mullvad-browser#80 (closed).

In particular, we need to save some stuff in the registry when we install the browser.

Then we have to clean them when we uninstall it.

Most of it has been adapted form Firefox's installers.

These NSIS changes require some new plugins.

Instead of finding hard ways to include them in the built, since Firefox includes their source code, I decided to build them when building Firefox, and add them to the exported artifactsm even though this means we always rebuild a couple of plugins.

How Tested

See mullvad-browser!108 (merged).

Merge request reports