Skip to content

Bug 41102: Compress firefox source tarball in a container

boklm requested to merge boklm/tor-browser-build:bug_41102 into main

Merge Info

Related Issues



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain - fix reproducibility issue

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

As the xz version on the host can be different and produce different
output, we compress the firefox source tarball inside a container.

At the same time we use xz's --threads option to make compression
faster by using multiple threads.

We also move the src-tarballs step definition from rbm.conf to
projects/firefox/config since it's not used in any other project.

How Tested

Ran make torbrowser-nightly-src and checked that it uses the same container as macos builds.

I also ran make torbrowser-nightly-macos to check that it still builds (as it is using firefox source tarball during the build).

Edited by Pier Angelo Vendrame

Merge request reports