Skip to content

Bug 41128: Fix spaces in various config files.

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_41128 into main

Merge Info

Related Issues

  • tor-browser#xxxxx
  • mullvad-browser#xxxxx
  • #41128



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

As a first step for #41128, we could cleanup some overabundant spaces from our config files.

Once run, it will be possible to update config files with ruamel.yaml (if you provide the correct indentation settings).

I don't think we'll actually manage to setup automation before 13.5 becomes stable, so I'd say no backport, but in case we could create a similar MR (so, coherency case).

I'm not going to consider the issue closed after this, in case we want to discuss more about formatting, etc.

How Tested

Not tested.

Checked the diff contains only spaces.

Merge request reports