Skip to content

Bug 41129: Make an rpm package for Mullvad Browser

boklm requested to merge boklm/tor-browser-build:bug_41129 into main

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : jwilde, ma1
    • signing : boklm, richard
    • updater : pierov
    • windows : jwilde, richard
    • misc/other : pierov, richard

Change Description

This adds an rpm package for Mullvad Browser.

This also changes how we install files in the Debian package: instead of using debian/install and debian/links files, we add an install rule in the Makefile to do the same, so that we can use it in the rpm package too.

This also changes the package version number to remove the -buildN part, since rpm doesn't like version numbers with a -.

Since the version of rpm in stretch does not have support for macros such as %clamp_mtime_to_source_date_epoch to make the build reproducible, we're building deb and rpm packages separately, and use a bookworm container for the rpm part.

How Tested

I checked that the build is reproducible when building on tb-build-02 and tb-build-03.

I installed the package in a Fedora 36 VM and was able to use the browser.

Edited by boklm

Merge request reports