Skip to content
GitLab
  • Explore
  • Sign in
  • The Tor Project
  • Applications
  • tor-browser-spec
  • Issues
  • #40057

FF110 Audit

General

The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).

The output includes the entire patch where the new problematic code was introduced. Search for XXX MATCH XXX to find the next potential violation.

code_audit.sh contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.

Firefox: https://github.com/mozilla/gecko-dev.git

  • Start: b89c6dedbd57992efe751d1b585116f2eaa34481 ( FIREFOX_109_0_1_RELEASE )
  • End: 250178df19caa1fb25bfa0e35728426cfbde95f8 ( FIREFOX_110_0_1_RELEASE )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)


Application Services: https://github.com/mozilla/application-services.git

  • Start: 102fa0de36a21b1b2f561ba6de557e20d05b7380 ( v96.3.0 )
  • End: 5755d9ce30ef10248eb55c4b39a522a118ce7d95 ( v97.1.0 )

Languages:

  • java
  • cpp
  • js
  • rust

Problematic Commits

  • Create shared remote settings client and port Nimbus to it 1d55a254fb6817c538ce19666cc02196c61170e6

Firefox Android: https://github.com/mozilla-mobile/firefox-android.git

  • Start: a7e03da7c26d76bea2fb9c77efce9d841d81f4e0
  • End: bc529747751ab545dba0a90a339f11382d742c97

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)

Fenix: https://github.com/mozilla-mobile/fenix.git

  • Start: efb2198489bbf27e18e434306183667cf4df0526 ( v110.0b1 )
  • End: 43c570380c5aa091f361018f038fa37cbfa71662 ( v110.0.1 )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)

Ticket Review

Bugzilla Query: https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=$(FIREFOX_VERSION)%20Branch&order=priority%2Cbug_severity&limit=0

Problematic Tickets

  • Add about:preferences entry for cookie banner handling https://bugzilla.mozilla.org/show_bug.cgi?id=1800675
    • tor-browser#41981 (closed)
    • RESOLUTION disabling for 13.0 and revisiting for the 13.5 alpha series
  • Add Cocoa platform support for paste files https://bugzilla.mozilla.org/show_bug.cgi?id=1762392
    • tor-browser#41982 (closed)
    • RESOLUTION has to deal with pasting into tor-browser, not exfiltration of data out, so we're good here
  • Create a reusable "support-link" widget https://bugzilla.mozilla.org/show_bug.cgi?id=1770447
    • tor-browser#41983 (closed)
    • RESOLUTION not an issue, just a hint to us for future UX work

Export

  • Export Report and save to tor-browser-spec/audits
Edited Sep 27, 2023 by richard
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking