Skip to content
Snippets Groups Projects
Commit 02106ccc authored by Pier Angelo Vendrame's avatar Pier Angelo Vendrame :jack_o_lantern:
Browse files

fixup! Bug 23247: Communicating security expectations for .onion

Fix a TypeError in _hasCustomRoot.

After this fix opening the identity panel will not result in a JS error
anymore. However, the identity panel will not be accurate for Onion
sites anyway.
parent ed6c1352
Branches
No related tags found
1 merge request!1049Bug 42616 (part 2): Rebased onto Firefox 128.0esr release
......@@ -807,7 +807,11 @@ var gIdentityHandler = {
* built-in (returns false) or imported (returns true).
*/
_hasCustomRoot() {
return !this._secInfo.isBuiltCertChainRootBuiltInRoot;
// HTTP Onion Sites are considered secure, but will not not have _secInfo.
// FIXME: Self-signed HTTPS Onion Sites are also deemed secure, but this
// function will return true for them, creating a warning about an exception
// that cannot be actually removed.
return !!this._secInfo && !this._secInfo.isBuiltCertChainRootBuiltInRoot;
},
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment