fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...

fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Bug 42425: Move the accessible name of the emoji cells from the cell to
its image child.

NVDA only reads the text content of a cell when navigating a "table".

Also, change the "table" in the user provide dialog to use the role
"cell" rather than "gridcell" (the later is only meant for the "grid"
role).

The "Emoji" description is incorporated into the "alt" of the image
instead. Before the description was not read out when doing screen
reader table navigation with either Orca or NVDA.

browser/components/torpreferences/content/bridgemoji/BridgeEmoji.js

@@ -119,7 +119,7 @@
         doc.defaultView.console.error(`No emoji for index ${this.#index}`);
         emojiName = unknownString;
       }
-      doc.l10n.setAttributes(this, "tor-bridges-emoji-cell", {
+      doc.l10n.setAttributes(this.#img, "tor-bridges-emoji-image", {
         emojiName,
       });
     }

browser/components/torpreferences/content/connectionPane.js

@@ -253,19 +253,11 @@ const gBridgeGrid = {
    */
   _rowTemplate: null,
 
-  /**
-   * @typedef {object} EmojiCell
-   *
-   * @property {Element} cell - The grid cell element.
-   * @property {Element} img - The grid cell icon.
-   * @property {Element} index - The emoji index.
-   */
   /**
    * @typedef {object} BridgeGridRow
    *
    * @property {Element} element - The row element.
    * @property {Element} optionsButton - The options button.
-   * @property {EmojiCell[]} emojis - The emoji cells.
    * @property {Element} menu - The options menupopup.
    * @property {Element} statusEl - The bridge status element.
    * @property {Element} statusText - The status text.

browser/components/torpreferences/content/provideBridgeDialog.js

@@ -469,7 +469,7 @@ const gProvideBridgeDialog = {
       for (const cell of BridgeEmoji.createForAddress(bridgeLine)) {
         // Each emoji is its own cell, we rely on the fact that createForAddress
         // always returns four elements.
-        cell.setAttribute("role", "gridcell");
+        cell.setAttribute("role", "cell");
         cell.classList.add("tor-bridges-grid-cell", "tor-bridges-emoji-cell");
         emojiBlock.append(cell);
       }

browser/components/torpreferences/content/provideBridgeDialog.xhtml

@@ -75,13 +75,13 @@
         <html:div class="tor-bridges-grid-row" role="row">
           <html:span
             class="tor-bridges-type-cell tor-bridges-grid-cell"
-            role="gridcell"
+            role="cell"
           ></html:span>
           <html:span class="tor-bridges-emojis-block" role="none"></html:span>
           <html:span class="tor-bridges-grid-end-block" role="none">
             <html:span
               class="tor-bridges-address-cell tor-bridges-grid-cell"
-              role="gridcell"
+              role="cell"
             >
               <html:span class="tor-bridges-address-cell-text"></html:span>
             </html:span>