fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...

fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Bug 42336: Rework the relationship between TorSettings and TorProvider.

browser/components/torpreferences/content/connectionPane.js

@@ -114,10 +114,9 @@ async function setTorSettings(changes) {
     // This will trigger TorSettings.#cleanupSettings()
     TorSettings.saveToPrefs();
     try {
-      // May throw.
       await TorSettings.applySettings();
     } catch (e) {
-      console.error("Failed to save Tor settings", e);
+      console.error("Failed to apply Tor settings", e);
     }
   } finally {
     TorSettings.thawNotifications();

browser/components/torpreferences/content/connectionSettingsDialog.js

@@ -362,6 +362,8 @@ const gConnectionSettingsDialog = {
     }
 
     TorSettings.saveToPrefs();
+    // FIXME: What if this fails? Should we prevent the dialog to close and show
+    // an error?
     TorSettings.applySettings();
   },
 };