Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Tor Browser
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
The Tor Project
Applications
Tor Browser
Commits
6922e094
Commit
6922e094
authored
5 months ago
by
cypherpunks1
Committed by
morgan
5 months ago
Browse files
Options
Downloads
Patches
Plain Diff
fixup! [android] Modify UI/UX
Bug 43052: Hide normal and synced tabs in the tabs tray
parent
192b9bf7
Loading
Loading
2 merge requests
!1203
Bug 43052: Hide normal and synced tabs in the tabs tray (Android)
,
!1202
Bug_43099: 2024 YEC Strings
Pipeline
#204774
passed
5 months ago
Stage: setup
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
+17
-11
17 additions, 11 deletions
...rc/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
with
17 additions
and
11 deletions
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
+
17
−
11
View file @
6922e094
...
...
@@ -50,6 +50,7 @@ import org.mozilla.fenix.compose.Divider
import
org.mozilla.fenix.compose.MenuItem
import
org.mozilla.fenix.compose.TabCounter
import
org.mozilla.fenix.compose.annotation.LightDarkPreview
import
org.mozilla.fenix.ext.settings
import
org.mozilla.fenix.tabstray.ext.getMenuItems
import
org.mozilla.fenix.theme.FirefoxTheme
import
kotlin.math.max
...
...
@@ -192,6 +193,7 @@ private fun TabPageBanner(
onTabPageIndicatorClicked
:
(
Page
)
->
Unit
,
onDismissClick
:
()
->
Unit
,
)
{
val
shouldDisableNormalMode
=
LocalContext
.
current
.
settings
().
shouldDisableNormalMode
val
selectedColor
=
FirefoxTheme
.
colors
.
iconActive
val
inactiveColor
=
FirefoxTheme
.
colors
.
iconPrimaryInactive
var
showMenu
by
remember
{
mutableStateOf
(
false
)
}
...
...
@@ -216,22 +218,24 @@ private fun TabPageBanner(
)
{
CompositionLocalProvider
(
LocalRippleTheme
provides
DisabledRippleTheme
)
{
TabRow
(
selectedTabIndex
=
selectedPage
.
ordinal
,
selectedTabIndex
=
if
(
shouldDisableNormalMode
)
0
else
selectedPage
.
ordinal
,
modifier
=
Modifier
.
fillMaxWidth
(
MAX_WIDTH_TAB_ROW_PERCENT
),
backgroundColor
=
Color
.
Transparent
,
contentColor
=
selectedColor
,
divider
=
{},
)
{
Tab
(
selected
=
selectedPage
==
Page
.
NormalTabs
,
onClick
=
{
onTabPageIndicatorClicked
(
Page
.
NormalTabs
)
},
modifier
=
Modifier
.
fillMaxHeight
()
.
testTag
(
TabsTrayTestTag
.
normalTabsPageButton
),
selectedContentColor
=
selectedColor
,
unselectedContentColor
=
inactiveColor
,
)
{
TabCounter
(
tabCount
=
normalTabCount
)
if
(!
shouldDisableNormalMode
)
{
Tab
(
selected
=
selectedPage
==
Page
.
NormalTabs
,
onClick
=
{
onTabPageIndicatorClicked
(
Page
.
NormalTabs
)
},
modifier
=
Modifier
.
fillMaxHeight
()
.
testTag
(
TabsTrayTestTag
.
normalTabsPageButton
),
selectedContentColor
=
selectedColor
,
unselectedContentColor
=
inactiveColor
,
)
{
TabCounter
(
tabCount
=
normalTabCount
)
}
}
Tab
(
...
...
@@ -250,6 +254,7 @@ private fun TabPageBanner(
unselectedContentColor
=
inactiveColor
,
)
/*
Tab(
selected = selectedPage == Page.SyncedTabs,
onClick = { onTabPageIndicatorClicked(Page.SyncedTabs) },
...
...
@@ -265,6 +270,7 @@ private fun TabPageBanner(
selectedContentColor = selectedColor,
unselectedContentColor = inactiveColor,
)
*/
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment