Verified Commit 7017edb5 authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez Committed by ma1
Browse files

Bug 2060048 - Force revalidation of Vary: cookie subresources. a=diannaS 

I think this would fix the image, css, and script caches.

Original Revision: https://phabricator.services.mozilla.com/D315988

Differential Revision: https://phabricator.services.mozilla.com/D317319
parent 723477b9

dom/base/nsContentUtils.cpp

+17 −0
Original line number Diff line number Diff line
@@ -12196,6 +12196,23 @@ nsContentUtils::GetSubresourceCacheValidationInfo(nsIRequest* aRequest, 
    if (!info.mMustRevalidate) {

      Unused << httpChannel->IsNoCacheResponse(&info.mMustRevalidate);

    }



    if (!info.mMustRevalidate) {

      nsAutoCString vary;

      (void)httpChannel->GetResponseHeader("vary"_ns, vary);

      info.mMustRevalidate = [&] {

        for (const nsACString& token :

             nsCCharSeparatedTokenizer(vary, ',').ToRange()) {

          if (token.EqualsLiteral("*")) {

            return true;

          }

          if (token.EqualsIgnoreCase("cookie")) {

            return true;

          }

        }

        return false;

      }();

    }

  }



  // data: URIs are safe to cache across documents under any circumstance, so we