-
- Downloads
Bug 1828517 (MOZ) - Improve rtp packet delivery through MediaPipeline and...
Bug 1828517 (MOZ) - Improve rtp packet delivery through MediaPipeline and conduits. r=webrtc-reviewers,dbaker With earlier fixes to upstream's PacketReceiver::DeliverPacket, received rtp packets were parsed twice: - In MediaPipeline, with the proper extension map in order to extract the header for filtering. - In conduits, with no extension map. The conduits would therefore not parse any rtp header extensions, leading to problems later on as data from the extensions would not get exposed to libwebrtc or js. This patch removes the rtp packet parsing in the conduits and moves any setting of metadata over to MediaPipeline so there is a single point responsible for parsing rtp packets. The packet is then transferred verbatim via the conduits to libwebrtc. Differential Revision: https://phabricator.services.mozilla.com/D177536
Showing
- dom/media/webrtc/libwebrtcglue/AudioConduit.cpp 4 additions, 14 deletionsdom/media/webrtc/libwebrtcglue/AudioConduit.cpp
- dom/media/webrtc/libwebrtcglue/AudioConduit.h 4 additions, 2 deletionsdom/media/webrtc/libwebrtcglue/AudioConduit.h
- dom/media/webrtc/libwebrtcglue/MediaConduitInterface.h 4 additions, 2 deletionsdom/media/webrtc/libwebrtcglue/MediaConduitInterface.h
- dom/media/webrtc/libwebrtcglue/VideoConduit.cpp 5 additions, 18 deletionsdom/media/webrtc/libwebrtcglue/VideoConduit.cpp
- dom/media/webrtc/libwebrtcglue/VideoConduit.h 4 additions, 2 deletionsdom/media/webrtc/libwebrtcglue/VideoConduit.h
- dom/media/webrtc/transportbridge/MediaPipeline.cpp 15 additions, 20 deletionsdom/media/webrtc/transportbridge/MediaPipeline.cpp
- dom/media/webrtc/transportbridge/MediaPipeline.h 8 additions, 3 deletionsdom/media/webrtc/transportbridge/MediaPipeline.h
- media/webrtc/signaling/gtest/MockConduit.h 3 additions, 2 deletionsmedia/webrtc/signaling/gtest/MockConduit.h
Loading
Please register or sign in to comment