Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Tor Browser
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Container registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
The Tor Project
Applications
Tor Browser
Commits
d82118fe
Commit
d82118fe
authored
7 months ago
by
Dan Ballard
Committed by
Pier Angelo Vendrame
6 months ago
Browse files
Options
Downloads
Patches
Plain Diff
fixup! [android] Modify build system
Always set gradle pref for nimbusFml as tbb's env var NIMBUS_FML supercedes it
parent
a9d1a752
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!1503
TB 43415, part 3: Shuffle commits
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
mobile/android/fenix/app/build.gradle
+7
-6
7 additions, 6 deletions
mobile/android/fenix/app/build.gradle
with
7 additions
and
6 deletions
mobile/android/fenix/app/build.gradle
+
7
−
6
View file @
d82118fe
...
...
@@ -330,12 +330,13 @@ android.applicationVariants.configureEach { variant ->
def
isDebugOrDCD
=
isDebug
||
isDataCollectionDisabled
def
useReleaseVersioning
=
variant
.
buildType
.
buildConfigFields
[
'USE_RELEASE_VERSIONING'
]?.
value
?:
false
// only set this property to pass to our patched application-service if it's defined in
// local.poperties, indicating this is a local dev build,
// otherwise we are in a TBB build env and the env var should be set and will be picked up
if
(
gradle
.
hasProperty
(
'localProperties.dependencySubstitutions.geckoviewTopsrcdir'
))
{
System
.
setProperty
(
"nimbusFml"
,
"${topsrcdir}/mobile/android/fenix/tools/nimbus-fml"
)
}
// env var NIMBUS_FML always overrides this in the tbb built patched application services
// https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/main/projects/application-services/offline-nimbus-fml.diff?ref_type=heads
// so safe to have always set so local builds and supply their expected location as fetched by
// fenix/tools/tba-fetch-deps.sh
// We normalize the path because it is valid to open/build from both tb and fenix roots
def
normalizedTBPath
=
rootProject
.
projectDir
.
absolutePath
.
minus
(
"mobile/android/fenix"
)
System
.
setProperty
(
"nimbusFml"
,
normalizedTBPath
+
"/mobile/android/fenix/tools/nimbus-fml"
)
println
(
"----------------------------------------------"
)
println
(
"Variant name: "
+
variant
.
name
)
...
...
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment