Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Tor Browser
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Container registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
The Tor Project
Applications
Tor Browser
Commits
da39cdcd
Verified
Commit
da39cdcd
authored
Sep 16, 2024
by
cypherpunks1
Committed by
Pier Angelo Vendrame
Sep 25, 2024
Browse files
Options
Downloads
Patches
Plain Diff
fixup! [android] Modify UI/UX
Bug 43052: Hide normal and synced tabs in the tabs tray
parent
4850ec8c
Branches
Branches containing commit
No related tags found
1 merge request
!1222
Bug 43166: Rebased alpha onto 128.3.0esr
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
+17
-11
17 additions, 11 deletions
...rc/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
with
17 additions
and
11 deletions
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
+
17
−
11
View file @
da39cdcd
...
...
@@ -50,6 +50,7 @@ import org.mozilla.fenix.compose.Divider
import
org.mozilla.fenix.compose.MenuItem
import
org.mozilla.fenix.compose.TabCounter
import
org.mozilla.fenix.compose.annotation.LightDarkPreview
import
org.mozilla.fenix.ext.settings
import
org.mozilla.fenix.tabstray.ext.getMenuItems
import
org.mozilla.fenix.theme.FirefoxTheme
import
kotlin.math.max
...
...
@@ -192,6 +193,7 @@ private fun TabPageBanner(
onTabPageIndicatorClicked
:
(
Page
)
->
Unit
,
onDismissClick
:
()
->
Unit
,
)
{
val
shouldDisableNormalMode
=
LocalContext
.
current
.
settings
().
shouldDisableNormalMode
val
selectedColor
=
FirefoxTheme
.
colors
.
iconActive
val
inactiveColor
=
FirefoxTheme
.
colors
.
iconPrimaryInactive
var
showMenu
by
remember
{
mutableStateOf
(
false
)
}
...
...
@@ -216,12 +218,13 @@ private fun TabPageBanner(
)
{
CompositionLocalProvider
(
LocalRippleTheme
provides
DisabledRippleTheme
)
{
TabRow
(
selectedTabIndex
=
selectedPage
.
ordinal
,
selectedTabIndex
=
if
(
shouldDisableNormalMode
)
0
else
selectedPage
.
ordinal
,
modifier
=
Modifier
.
fillMaxWidth
(
MAX_WIDTH_TAB_ROW_PERCENT
),
backgroundColor
=
Color
.
Transparent
,
contentColor
=
selectedColor
,
divider
=
{},
)
{
if
(!
shouldDisableNormalMode
)
{
Tab
(
selected
=
selectedPage
==
Page
.
NormalTabs
,
onClick
=
{
onTabPageIndicatorClicked
(
Page
.
NormalTabs
)
},
...
...
@@ -233,6 +236,7 @@ private fun TabPageBanner(
)
{
TabCounter
(
tabCount
=
normalTabCount
)
}
}
Tab
(
selected
=
selectedPage
==
Page
.
PrivateTabs
,
...
...
@@ -250,6 +254,7 @@ private fun TabPageBanner(
unselectedContentColor
=
inactiveColor
,
)
/*
Tab(
selected = selectedPage == Page.SyncedTabs,
onClick = { onTabPageIndicatorClicked(Page.SyncedTabs) },
...
...
@@ -265,6 +270,7 @@ private fun TabPageBanner(
selectedContentColor = selectedColor,
unselectedContentColor = inactiveColor,
)
*/
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment