Skip to content
Snippets Groups Projects
Commit df3eae24 authored by morgan's avatar morgan :smile_cat: Committed by Pier Angelo Vendrame
Browse files

fixup! BB 43615: Add Gitlab Issue and Merge Request templates

add new and modify existing shared Tor/Mullvad browser templates
parent 63e55964
Branches
Tags
1 merge request!1502TB 43415 (part 2): Cherry-picks from 128.9.0esr
# 🐞 Bug Report
<!--
Use this template to report problems with the browser which are unrelated to
website functionality (please use the Web Compatibility template for such issues).
The issue's title MUST provide a succinct description of the problem.
Some good (hypothetical) titles:
- Browser crashes when visiting example.com in Safer mode
- Letterboxing appears even when disabled when using tiling window-manager
- All fonts in browser-chrome have serifs
Please DO NOT include information about platform in the title, it is redundant
with our labeling system!
-->
## Reproduction steps
<!--
Provide specific steps developers can follow to reproduce your issue.
-->
## Expected behaviour
<!--
Provide a description of the browser feature or scenario which does not appear
to be working.
-->
## Actual behaviour
<!--
Provide a description of what actually occurs.
-->
## Bookkeeping
<!--
Please provide the following information:
-->
- Browser version:
- Browser channel:
- [ ] Release
- [ ] Alpha
- [ ] Nightly
- Distribution method:
- [ ] Installer/archive from torproject.org
- [ ] tor-browser-launcher
- [ ] homebrew
- [ ] other (please specify):
- Operating System:
- [ ] Windows
- [ ] macOS
- [ ] Linux
- [ ] Android
- [ ] Tails
- [ ] Other (please specify):
- Operating System Version:
### Browser UI language
<!--
Found in `about:preferences#general`.
Feel free to omit this if you like, but sometimes bugs can be language specific so having
this info may make it easier for developers to reproduce your problem.
-->
### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
<!--
If you changed any preference in about:config that aren't exposed in a UI,
could you try to see if you can reproduce without them? Generally speaking, such
changes are unsupported and bugs might be closed as invalid.
-->
### Do you have any extra extensions installed?
<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
## Troubleshooting
<!--
This is optional, but it will help to resolve your problem.
-->
### Does this bug occur in a fresh installation?
### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
<!--
Archived packages for past versions can be found here:
- https://archive.torproject.org/tor-package-archive
-->
### Does this bug occur in the Alpha release channel?
<!--
Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
⚠️ However, the Alpha release channel is the development version and as such may be contain
critical bugs not present in the Stable release channel. Do not test in Alpha if you are an
at risk user unless you really, actually, truly know what you are doing!
The latest Alpha can be found here:
- https://www.torproject.org/download/alpha/
-->
### Does this bug occur in Firefox ESR (Desktop only)?
<!--
Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
also be present in Tor Browser.
Firefox ESR is available for download here:
- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
-->
### Does this bug occur in Firefox Rapid Release?
<!--
If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
to identify and backport the patch which fixes it.
Firefox Rapid Release is available for download here:
- https://www.mozilla.org/en-US/firefox/new/
If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
-->
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Bug"
# 💡 Proposal
<!--
Use this template to request a feature or propose some change in the browser.
The issue will likely be edited many times over its life to flesh out the various
questions, so if you don't know the answers to something, jut leave it blank!
The issue's title MUST provide a succinct description of proposal.
Some good (hypothetical) titles:
- Remove 'Safer' option from Security Level
- Bundle uBlock Origin by default
- Replace NoScript with faith-based JavaScript sand-boxing
-->
## User Story
<!--
Provide a high-level summary of the proposed feature, the problem it solves, and
what it would allow users to do if implemented. -->
## Security and Privacy Implications
<!--
How would this proposal interact with our the browser's threat model?
Would this feature negatively affect the browser's security or privacy
guarantees?
-->
### Security
<!--
Outline any security implications this feature would introduce. The browser's
security requirements can be found in our threat model document here:
- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#21-security-requirements
-->
### Privacy
<!--
Outline any privacy implications this feature would introduce. The browser's
privacy requirements can be found in our threat model document here:
- https://gitlab.torproject.org/tpo/applications/wiki/-/wikis/Design-Documents/Tor-Browser-Design-Doc#22-privacy-requirements
-->
## Accessibility Implications
<!--
Would this proposal affect or interact with the browser's usability for users
with accessibility needs (e.g. vision or mobility issues). What problems would need
to be solved to ensure these users are not left behind?
-->
## Other Trade-Offs
<!--
Beyond the security, privacy and accessibility implications, what other implications
are there for users?
-->
## Prior Art
### Does this feature exist in other browsers?
- [ ] Yes
- [ ] Firefox
- [ ] Firefox ESR
- [ ] Other (please specify)
- [ ] No
### Does this feature exist as an extension? If yes, which one provides this functionality?
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Proposal"
# 🌍 Web Compatibility
<!--
Use this template to report websites which do not work properly in the browser.
The issue's title MUST provide a succinct description of the problem.
Some good (hypothetical) titles:
- Road signs do not render correctly on maps.foo.com
- Infinite CAPTCHA prompts on bar.nat
- Cannot login to baz.org
-->
## URL
<!-- Provide a link to the website -->
## Expected behaviour
<!--
Provide a description of the how the website is supposed to work
-->
## Actual behaviour
<!--
Provide a description of what actually occurs
-->
## Reproduction steps
<!--
Provide specific steps developers can follow to reproduce your issue
-->
## Bookkeeping
<!--
Please provide the following information:
-->
- Browser version:
- Browser channel:
- [ ] Release
- [ ] Alpha
- [ ] Nightly
- Distribution method:
- [ ] Installer/archive from torproject.org
- [ ] tor-browser-launcher
- [ ] homebrew
- [ ] other (please specify):
- Operating System:
- [ ] Windows
- [ ] macOS
- [ ] Linux
- [ ] Android
- [ ] Tails
- [ ] Other (please specify):
- Operating System Version:
### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones?
<!--
If you changed any preference in about:config that aren't exposed in a UI,
could you try to see if you can reproduce without them? Generally speaking, such
changes are unsupported and bugs might be closed as invalid.
-->
### Do you have any extra extensions installed?
<!-- e.g. Firefox Multi-Account Containers, uBlock Origin, etc -->
## Troubleshooting
<!--
This is optional, but it will help to resolve your problem.
-->
### Does this bug occur in a fresh installation?
### Is this bug new? If it is a regression, in which version of the browser did this bug first appear?
<!--
Archived packages for past versions can be found here:
- https://archive.torproject.org/tor-package-archive
-->
### Does this bug occur in the Alpha release channel?
<!--
Sometimes bugs are fixed in the Alpha (development) channel but not in the Stable channel.
⚠️ However, the Alpha release channel is the development version and as such may be contain
critical bugs not present in the Stable release channel. Do not test in Alpha if you are an
at risk user unless you really, actually, truly know what you are doing!
The latest Alpha can be found here:
- https://www.torproject.org/download/alpha/
-->
### Does this bug occur in Firefox ESR (Desktop only)?
<!--
Tor Browser is based on Firefox ESR, so any bugs present in this upstream project will likely
also be present in Tor Browser.
Firefox ESR is available for download here:
- https://www.mozilla.org/en-US/firefox/all/desktop-esr/
-->
### Does this bug occur in Firefox Rapid Release?
<!--
If the issue occurs in Firefox ESR, but does not occur in Firefox Rapid Release, we may be able
to identify and backport the patch which fixes it.
Firefox Rapid Release is available for download here:
- https://www.mozilla.org/en-US/firefox/new/
If the issue has been fixed in Firefox, do you know the Bugzilla issue number associated with the fix?
-->
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::WebCompatibility"
# 💣 Test
<!--
Use this template to track testing of some feature. Please
try to make the title a good one-liner for the changelogs!
Some good (hypothetical) titles:
- Add test exercising new circuit button
- Add tests for verifying built-in bridge connectivity
- Develop a mock Lox authority for automated testing
-->
## Description
<!--
Provide an overview of the technical/implementation aspects of this
test work a developer would need to know
-->
## Scenarios
<!--
Provide a list of high-level classes of desired test-cases
and the expected behaviour of each
-->
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Test"
# ✨ Feature
<!--
Use this template to track implementation of some feature. Please
try to make the title a good one-liner for the changelogs!
Some good (hypothetical) titles:
- Bundle AwesomeFont Sans Font
- Implement new user on-boarding UX
- Publish Linux aarch64 alpha builds
-->
## Description
<!--
Provide an overview of the technical/implementation aspects of this feature
-->
## Bookkeeping
### Proposal
<!-- Add links to associated proposal issues (or delete block) -->
- tor-browser#12345
### Design
<!-- Add links to associated design issues (or delete block) -->
- tpo/UX/Design#123
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Feature"
# ⬅️ Backport Patchset
<!--
Title:
Backport tor-browser#12345: Title of Issue
Backport Bugzilla 1234567: Title of Issue
This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from
Mozilla Rapid-Release to Alpha).
This is an issue for tracking back-porting a patch-set (e.g. from Alpha to Stable or from Mozilla Rapid-Release to Alpha)
-->
please ensure the title has the following format:
- Backport tor-browser#12345: Title of original issue
- Backport Bugzilla 1234567: Title of original issue
## Backport Patchset
-->
### Book-keeping
## Bookkeeping
#### Issue(s)
### Issue(s)
- tor-browser#12345
- mullvad-browser#123
- https://bugzilla.mozilla.org/show_bug.cgi?id=1234567
#### Merge Request(s)
### Merge Request(s)
- tor-browser!123
#### Target Channels
### Target Channels
- [ ] Alpha
- [ ] Stable
- [ ] Legacy
### Notes
## Notes
<!-- whatever additional info, context, etc that would be helpful for backporting -->
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Backport"
# ⤵️ Rebase Alpha
**NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
<details>
......@@ -152,4 +154,10 @@
- [ ] Update `firefox_platform_version`
- [ ] Set `browser_build` to 1 (to prevent failures in alpha testbuilds)
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Rebase"
/label ~"Apps::Priority::Blocker"
# ⤵️ Rebase Stable
**NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr
<details>
......@@ -114,4 +116,10 @@
```
- [ ] Push tag to `upstream`
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Rebase"
/label ~"Apps::Priority::Blocker"
# ⤵️ Rebase Rapid
- **NOTE**: All examples in this template reference the rebase from Firefox 129.0a1 to 130.0a1
- **TODO**:
- Documentation step for any difficulties or noteworthy things for each rapid rebase
......@@ -289,4 +291,10 @@ gitGraph:
```
- [ ] Push tag to `upstream`
<!-- Do not edit beneath this line <3 -->
---
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Type::Rebase"
/label ~"Apps::Priority::High"
# 🚨 Emergency Security Issue
**NOTE** This is an issue template to standardise our process for responding to and fixing critical security and privacy vulnerabilities, exploits, etc.
## Information
......@@ -31,9 +33,10 @@
- [ ] **clairehurst** : Android, macOS
- [ ] **dan** : Android, macOS
- [ ] **henry** : accessibility, frontend, localisation
- [ ] **jwilde** : windows, firefox internals
- [ ] **ma1** : firefox internals
- [ ] **pierov** : updater, fonts, localisation, general
- [ ] **richard** : signing, release
- [ ] **morgan** : signing, release
- [ ] **thorin** : fingerprinting
- [ ] Other Engineering Teams
- [ ] Networking (**ahf**, **dgoulet**)
......@@ -80,11 +83,20 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad
- [ ] **(Optional)** **gazebook**
- if there are consequences to the organisation or partners beyond a browser update, then a communication plan may be needed
Godspeed! :pray:
<!-- Do not edit beneath this line <3 -->
---
/cc @bella
/cc @ma1
/cc @micah
/cc @richard
/cc @morgan
/confidential
Godspeed! :pray:
/label ~"Apps::Product::TorBrowser"
/label ~"Apps::Product::MullvadBrowser"
/label ~"Apps::Type::Bug"
/label ~"Apps::Priority::Blocker"
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment