Bug 1766375 - Disable implicit-fallthrough warnings in Windows builds like...

Bug 1766375 - Disable implicit-fallthrough warnings in Windows builds like other platforms. r=firefox-build-system-reviewers,andi

Also disable it for Windows-specific third-party code.

Differential Revision: https://phabricator.services.mozilla.com/D144667

dom/canvas/moz.build

@@ -175,8 +175,7 @@ TEST_DIRS += [
 ]
 
 # Suppress warnings from third-party code.
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    SOURCES["MurmurHash3.cpp"].flags += ["-Wno-implicit-fallthrough"]
+SOURCES["MurmurHash3.cpp"].flags += ["-Wno-implicit-fallthrough"]
 
 LOCAL_INCLUDES += [
     "/js/xpconnect/wrappers",

gfx/2d/moz.build

@@ -120,7 +120,7 @@ SOURCES += [
     "PathSkia.cpp",
     "SourceSurfaceSkia.cpp",
 ]
-if CONFIG["CC_TYPE"] == "clang":
+if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     # Suppress warnings from Skia header files.
     SOURCES["DrawTargetSkia.cpp"].flags += ["-Wno-implicit-fallthrough"]
     SOURCES["PathSkia.cpp"].flags += ["-Wno-implicit-fallthrough"]
@@ -194,7 +194,7 @@ SOURCES += [
     "InlineTranslator.cpp",
 ]
 
-if CONFIG["CC_TYPE"] == "clang":
+if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     SOURCES["Factory.cpp"].flags += ["-Wno-implicit-fallthrough"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":

gfx/thebes/moz.build

@@ -286,7 +286,7 @@ LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
 DEFINES["GRAPHITE2_STATIC"] = True
 
-if CONFIG["CC_TYPE"] == "clang":
+if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     # Suppress warnings from Skia header files.
     SOURCES["gfxPlatform.cpp"].flags += ["-Wno-implicit-fallthrough"]
 

js/src/util/moz.build

@@ -35,5 +35,4 @@ SOURCES += [
 ]
 
 # Suppress warnings in third-party code.
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    SOURCES["DoubleToString.cpp"].flags += ["-Wno-implicit-fallthrough"]
+SOURCES["DoubleToString.cpp"].flags += ["-Wno-implicit-fallthrough"]

mozglue/misc/moz.build

@@ -130,7 +130,7 @@ SOURCES += [
     "decimal/Decimal.cpp",
 ]
 
-if CONFIG["CC_TYPE"] == "clang":
+if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     # Suppress warnings from third-party V8 Decimal code.
     SOURCES["decimal/Decimal.cpp"].flags += ["-Wno-implicit-fallthrough"]
 

toolkit/crashreporter/crashreporter.mozbuild

@@ -27,9 +27,8 @@ if CONFIG['CC_TYPE'] in ('clang', 'clang-cl'):
          '-Wno-c++11-narrowing',
      ]
 
-if CONFIG['CC_TYPE'] != 'clang-cl':
-     CXXFLAGS += [
-         '-Wno-implicit-fallthrough',
-     ]
+CXXFLAGS += [
+    '-Wno-implicit-fallthrough',
+]
 
 DEFINES['NO_STABS_SUPPORT'] = True

toolkit/mozapps/defaultagent/moz.build

@@ -37,6 +37,9 @@ SOURCES += [
     "/toolkit/mozapps/update/common/readstrings.cpp",
 ]
 
+# Suppress warnings from third-party code.
+SOURCES["/third_party/WinToast/wintoastlib.cpp"].flags += ["-Wno-implicit-fallthrough"]
+
 USE_LIBS += [
     "defaultagent-static",
     "jsoncpp",