Skip to content
Snippets Groups Projects
Verified Commit ed8bc8b1 authored by Kathleen Brade's avatar Kathleen Brade Committed by Pier Angelo Vendrame
Browse files

Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.
parent 75871f8e
No related branches found
No related tags found
1 merge request!653Bug 41795: Rebased alpha to 102.12
......@@ -62,6 +62,7 @@ XPCOMUtils.defineLazyGetter(this, "AboutLoginsL10n", () => {
const ABOUT_LOGINS_ORIGIN = "about:logins";
const AUTH_TIMEOUT_MS = 5 * 60 * 1000; // 5 minutes
const PRIMARY_PASSWORD_NOTIFICATION_ID = "primary-password-login-required";
const NOCERTDB_PREF = "security.nocertdb";
// about:logins will always use the privileged content process,
// even if it is disabled for other consumers such as about:newtab.
......@@ -323,6 +324,7 @@ class AboutLoginsParent extends JSWindowActorParent {
importVisible:
Services.policies.isAllowed("profileImport") &&
AppConstants.platform != "linux",
canCreateLogins: !Services.prefs.getBoolPref(NOCERTDB_PREF, false),
});
await AboutLogins.sendAllLoginRelatedObjects(
......
......@@ -62,6 +62,11 @@ login-item[data-editing="true"] + login-intro,
display: none;
}
/* Do not promote Mozilla Sync. */
login-intro {
display: none !important;
}
.heading-wrapper {
display: flex;
justify-content: center;
......
......@@ -22,6 +22,9 @@ const gElements = {
".menuitem-remove-all-logins"
);
},
get createNewLoginButton() {
return this.loginList.shadowRoot.querySelector(".create-login-button");
},
};
let numberOfLogins = 0;
......@@ -128,6 +131,9 @@ window.addEventListener("AboutLoginsChromeToContent", event => {
gElements.loginList.setSortDirection(event.detail.value.selectedSort);
document.documentElement.classList.add("initialized");
gElements.loginList.classList.add("initialized");
if (!event.detail.value.canCreateLogins) {
gElements.createNewLoginButton.disabled = true;
}
break;
}
case "ShowLoginItemError": {
......
......@@ -8,6 +8,11 @@
align-items: center;
}
/* Do not promote Mozilla Sync. */
.logged-out-view {
display: none !important;
}
.fxaccounts-extra-text {
/* Only show at most 3 lines of text to limit the
text from overflowing the header. */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment